From: Thomas Garnier <thgarnie@google.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@suse.de>,
Andy Lutomirski <luto@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Dan Williams <dan.j.williams@intel.com>,
Kees Cook <keescook@chromium.org>,
Stephen Smalley <sds@tycho.nsa.gov>,
Seth Jennings <sjennings@variantweb.net>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Jonathan Corbet <corbet@lwn.net>,
Matt Fleming <matt@codeblueprint.co.uk>,
Toshi Kani <toshi.kani@hpe.com>,
Alexander Kuleshov <kuleshovmail@gmail.com>,
Alexander Popov <alpopov@ptsecurity.com>,
Joerg Roedel <jroedel@suse.de>, Dave Young <dyoung@redhat.com>,
Baoquan He <bhe@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Mark Salter <msalter@redhat.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, Greg Thelen <gthelen@google.com>,
kernel-hardening@lists.openwall.com
Subject: Re: [RFC v1 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64)
Date: Thu, 21 Apr 2016 08:52:01 -0700 [thread overview]
Message-ID: <CAJcbSZHoP-B1VD9jkxH_Ma8sy+F9uYYQeormi47VeRSq3qhSOw@mail.gmail.com> (raw)
In-Reply-To: <9AF9DCC7-8FC4-4A93-B75A-C07B8CD9023A@zytor.com>
On Thu, Apr 21, 2016 at 8:46 AM, H. Peter Anvin <hpa@zytor.com> wrote:
> On April 21, 2016 6:30:24 AM PDT, Boris Ostrovsky <boris.ostrovsky@oracle.com> wrote:
>>
>>
>>On 04/15/2016 06:03 PM, Thomas Garnier wrote:
>>> +void __init kernel_randomize_memory(void)
>>> +{
>>> + size_t i;
>>> + unsigned long addr = memory_rand_start;
>>> + unsigned long padding, rand, mem_tb;
>>> + struct rnd_state rnd_st;
>>> + unsigned long remain_padding = memory_rand_end - memory_rand_start;
>>> +
>>> + if (!kaslr_enabled())
>>> + return;
>>> +
>>> + /* Take the additional space when Xen is not active. */
>>> + if (!xen_domain())
>>> + page_offset_base -= __XEN_SPACE;
>>
>>This should be !xen_pv_domain(). Xen HVM guests are no different from
>>bare metal as far as address ranges are concerned. (Technically it's
>>probably !xen_pv_domain() && !xen_pvh_domain() but we can ignore PVH
>>for
>>now since it is being replaced by an HVM-type guest)
>>
>>Having said that, I am not sure I understand why page_offset_base is
>>shifted. I thought 0xffff800000000000 - 0xffff87ffffffffff is not
>>supposed to be used by anyone, whether we are running under a
>>hypervisor
>>or not.
>>
>>-boris
>
> That range is reserved for the hypervisor use.
I know, I thought I could use it if no hypervisor was used but might
introduce problems in the future so I will remove it for the next
iteration.
> --
> Sent from my Android device with K-9 Mail. Please excuse brevity and formatting.
next prev parent reply other threads:[~2016-04-21 15:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 22:03 [RFC v1 0/4] x86, boot: KASLR memory implementation (x86_64) Thomas Garnier
2016-04-15 22:03 ` [RFC v1 1/4] x86, boot: Refactor KASLR entropy functions Thomas Garnier
2016-04-15 22:03 ` [RFC v1 2/4] x86, boot: PUD VA support for physical mapping (x86_64) Thomas Garnier
2016-04-15 22:03 ` [RFC v1 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64) Thomas Garnier
2016-04-18 14:46 ` Joerg Roedel
2016-04-18 14:56 ` Thomas Garnier
2016-04-18 19:01 ` H. Peter Anvin
2016-04-19 14:27 ` Joerg Roedel
2016-04-19 15:49 ` Thomas Garnier
2016-04-21 13:30 ` Boris Ostrovsky
2016-04-21 15:11 ` Thomas Garnier
2016-04-21 15:46 ` H. Peter Anvin
2016-04-21 15:52 ` Thomas Garnier [this message]
2016-04-21 20:15 ` H. Peter Anvin
2016-04-21 20:18 ` Thomas Garnier
2016-06-17 9:07 ` Ingo Molnar
2016-06-17 9:35 ` Ingo Molnar
2016-06-17 9:40 ` Ingo Molnar
2016-04-15 22:03 ` [RFC v1 4/4] x86, boot: Memory hotplug support for KASLR memory randomization Thomas Garnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJcbSZHoP-B1VD9jkxH_Ma8sy+F9uYYQeormi47VeRSq3qhSOw@mail.gmail.com \
--to=thgarnie@google.com \
--cc=alpopov@ptsecurity.com \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=dyoung@redhat.com \
--cc=gthelen@google.com \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=msalter@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=sjennings@variantweb.net \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=wangkefeng.wang@huawei.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).