From: Hillf Danton <dhillf@gmail.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [ANNOUNCEMENT] The Barbershop Load Distribution algorithm for Linux kernel scheduler.
Date: Tue, 14 Feb 2012 20:59:25 +0800 [thread overview]
Message-ID: <CAJd=RBAAe212McM=26UDAt8_zrZgJFQewFjRyby2Za5m_Z+FDg@mail.gmail.com> (raw)
In-Reply-To: <CADZ9YHhGWd9DToiQDbvv4=BvN4DZLJMuvyLNUHjWqErGE3nXzQ@mail.gmail.com>
On Tue, Feb 14, 2012 at 1:22 AM, Rakib Mullick <rakib.mullick@gmail.com> wrote:
>>> +
>>> + if (rq->pos != 2) { /* if rq isn't the last one */
>>> + struct rq *last;
>>> + write_lock_irqsave(&disp_list_lock, flag);
>>
>> if (rq->pos != 2)
>> goto out;
>>
> At this point, we're checking whether this task is activating on a rq
> which is the last (hightest loaded) rq or not. If rq->pos != 2, it
> stands we're not activating a task at the highest loaded rq, so a
> check will be made with the highest loaded rq to make sure - this rq's
> loaded didn't exceed the highest loaded rq. If rq's load
> exceed - list will be removed from it's place and will be placed as a
> last entry of rq_head and thus it becomes the highest loaded rq. So,
> what you proposed here isn't what was intended.
>
I want to say
if (rq->pos == 2)
goto out;
sorry for the bad:(
> Hiff, did you ran the patch? Would like to know.
Try to run soon.
Best regards
Hillf
prev parent reply other threads:[~2012-02-14 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 18:52 [ANNOUNCEMENT] The Barbershop Load Distribution algorithm for Linux kernel scheduler Rakib Mullick
2012-02-13 14:05 ` Hillf Danton
2012-02-13 17:22 ` Rakib Mullick
2012-02-14 12:59 ` Hillf Danton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJd=RBAAe212McM=26UDAt8_zrZgJFQewFjRyby2Za5m_Z+FDg@mail.gmail.com' \
--to=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).