From: Hillf Danton <dhillf@gmail.com>
To: linux-mm@kvack.org
Cc: David Rientjes <rientjes@google.com>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] mm: vmscam: check page order in isolating lru pages
Date: Thu, 29 Dec 2011 20:45:14 +0800 [thread overview]
Message-ID: <CAJd=RBBJG+hLLc3mR-WzByU1gZEcdFUAoZzyir+1A4a0tVnSmg@mail.gmail.com> (raw)
Before we try to isolate physically contiguous pages, check for page order is
added, and if the reclaim order is no larger than page order, we should give up
the attempt.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Hugh Dickins <hughd@google.com>
---
--- a/mm/vmscan.c Thu Dec 29 20:20:16 2011
+++ b/mm/vmscan.c Thu Dec 29 20:28:14 2011
@@ -1162,6 +1162,7 @@ static unsigned long isolate_lru_pages(u
unsigned long end_pfn;
unsigned long page_pfn;
int zone_id;
+ unsigned int isolated_pages = 0;
page = lru_to_page(src);
prefetchw_prev_lru_page(page, src, flags);
@@ -1172,7 +1173,7 @@ static unsigned long isolate_lru_pages(u
case 0:
mem_cgroup_lru_del(page);
list_move(&page->lru, dst);
- nr_taken += hpage_nr_pages(page);
+ isolated_pages = hpage_nr_pages(page);
break;
case -EBUSY:
@@ -1184,8 +1185,11 @@ static unsigned long isolate_lru_pages(u
BUG();
}
+ nr_taken += isolated_pages;
if (!order)
continue;
+ if (isolated_pages != 1 && isolated_pages >= (1 << order))
+ continue;
/*
* Attempt to take all pages in the order aligned region
@@ -1227,7 +1231,6 @@ static unsigned long isolate_lru_pages(u
break;
if (__isolate_lru_page(cursor_page, mode, file) == 0) {
- unsigned int isolated_pages;
mem_cgroup_lru_del(cursor_page);
list_move(&cursor_page->lru, dst);
next reply other threads:[~2011-12-29 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 12:45 Hillf Danton [this message]
2011-12-29 17:35 ` [PATCH] mm: vmscam: check page order in isolating lru pages KOSAKI Motohiro
2011-12-31 14:55 ` Hillf Danton
2012-01-04 0:05 ` Andrew Morton
2012-01-05 6:20 ` KAMEZAWA Hiroyuki
2012-01-05 13:32 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJd=RBBJG+hLLc3mR-WzByU1gZEcdFUAoZzyir+1A4a0tVnSmg@mail.gmail.com' \
--to=dhillf@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).