From: Jassi Brar <jaswinder.singh@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Devicetree List <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"ks.giri@samsung.com" <ks.giri@samsung.com>,
Arnd Bergmann <arnd@arndb.de>, Ian Campbell <ijc@hellion.org.uk>,
Mark Rutland <mark.rutland@arm.com>,
robh@kernel.org, Pawel Moll <pawel.moll@arm.com>,
Courtney Cavin <courtney.cavin@sonymobile.com>,
Matt Porter <mporter@linaro.org>,
Craig McGeachie <slapdau@yahoo.com.au>,
LeyFoon Tan <lftan.linux@gmail.com>,
Loic Pallardy <loic.pallardy@st.com>,
"Anna, Suman" <s-anna@ti.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Bjorn Andersson <bjorn@kryo.se>,
Patch Tracking <patches@linaro.org>,
Tetsuya Takinishi <t.takinishi@jp.fujitsu.com>,
Mark Brown <broonie@linaro.org>,
Kevin Hilman <khilman@linaro.org>,
Mollie Wu <mollie.wu@linaro.org>,
Andy Green <andy.green@linaro.org>
Subject: Re: [PATCHv9 2/4] mailbox: Introduce framework for mailbox
Date: Thu, 31 Jul 2014 22:26:55 +0530 [thread overview]
Message-ID: <CAJe_ZhcOXyGO49sZUXnqCk9wm7WvQ01b76k7Wqxxi1S3qisDPA@mail.gmail.com> (raw)
In-Reply-To: <20140723152649.GJ23210@lee--X1>
On 23 July 2014 20:56, Lee Jones <lee.jones@linaro.org> wrote:
> On Wed, 23 Jul 2014, Jassi Brar wrote:
>> >> + if (chan->txdone_method == (TXDONE_BY_POLL | TXDONE_BY_ACK))
>> >> + chan->txdone_method = TXDONE_BY_POLL;
>> >
>> > Unless you're leaving it there for clarity, you can drop the
>> > "TXDONE_BY_POLL |" from if().
>> >
>> We need to check for both.
>
> What I'm trying to get at is; if it's already TXDONE_BY_POLL, there is no
> need to set it to TXDONE_BY_POLL.
>
In mbox_request_channel() we added the ACK flag, if POLL was set and
now we need to revert that in mbox_free_channel().
Thanks
Jassi
next prev parent reply other threads:[~2014-07-31 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 18:54 [PATCHv9 0/4] Common Mailbox Framework Jassi Brar
2014-07-22 18:55 ` [PATCHv9 1/4] mailbox: rename pl320-ipc specific mailbox.h Jassi Brar
2014-07-22 18:56 ` [PATCHv9 2/4] mailbox: Introduce framework for mailbox Jassi Brar
2014-07-23 8:54 ` Lee Jones
2014-07-23 15:00 ` Jassi Brar
2014-07-23 15:26 ` Lee Jones
2014-07-31 16:56 ` Jassi Brar [this message]
2014-08-01 8:17 ` Lee Jones
2014-07-31 17:32 ` Sudeep Holla
2014-07-22 18:57 ` [PATCHv9 3/4] doc: add documentation for mailbox framework Jassi Brar
2014-07-22 18:57 ` [PATCHv9 4/4] dt: mailbox: add generic bindings Jassi Brar
2014-07-28 13:50 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJe_ZhcOXyGO49sZUXnqCk9wm7WvQ01b76k7Wqxxi1S3qisDPA@mail.gmail.com \
--to=jaswinder.singh@linaro.org \
--cc=andy.green@linaro.org \
--cc=arnd@arndb.de \
--cc=ashwin.chaugule@linaro.org \
--cc=bjorn@kryo.se \
--cc=broonie@linaro.org \
--cc=courtney.cavin@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc@hellion.org.uk \
--cc=khilman@linaro.org \
--cc=ks.giri@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lftan.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=mark.rutland@arm.com \
--cc=mollie.wu@linaro.org \
--cc=mporter@linaro.org \
--cc=patches@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=s-anna@ti.com \
--cc=slapdau@yahoo.com.au \
--cc=t.takinishi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).