linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zheng Hacker <hackerzheng666@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Zheng Wang <zyytlz.wz@163.com>,
	maximlevitsky@gmail.com, oakad@yahoo.com,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	1395428693sheep@gmail.com, alex000young@gmail.com
Subject: Re: [PATCH] memstick: r592: Fix UAF bug in r592_remove due to race condition
Date: Sat, 11 Mar 2023 00:20:57 +0800	[thread overview]
Message-ID: <CAJedcCxrXuDjj_hGz7wizmfu1A9PNguNRNT85YVmkAHCG7ynYQ@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFoV9aZObZ5GBm0U_-UVeVkBN_rAG-kH3BKoP4EXdYM4bw@mail.gmail.com>

Ulf Hansson <ulf.hansson@linaro.org> 于2023年3月9日周四 23:02写道:
>
> On Tue, 7 Mar 2023 at 17:44, Zheng Wang <zyytlz.wz@163.com> wrote:
> >
> > In r592_probe, dev->detect_timer was bound with r592_detect_timer.
> > In r592_irq function, the timer function will be invoked by mod_timer.
> >
> > If we remove the module which will call hantro_release to make cleanup,
> > there may be a unfinished work. The possible sequence is as follows,
> > which will cause a typical UAF bug.
> >
> > Fix it by canceling the work before cleanup in r592_remove.
> >
> > CPU0                  CPU1
> >
> >                     |r592_detect_timer
> > r592_remove         |
> >   memstick_free_host|
> >   put_device;       |
> >   kfree(host);      |
> >                     |
> >                     | queue_work
> >                     |   &host->media_checker //use
> >
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
>
> Applied for next, thanks!
>
Sorry for my late reply and thanks for your effort!

Best regards,
Zheng
>
>
> > ---
> >  drivers/memstick/host/r592.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c
> > index 1d35d147552d..2bfa7eaae80a 100644
> > --- a/drivers/memstick/host/r592.c
> > +++ b/drivers/memstick/host/r592.c
> > @@ -829,7 +829,7 @@ static void r592_remove(struct pci_dev *pdev)
> >         /* Stop the processing thread.
> >         That ensures that we won't take any more requests */
> >         kthread_stop(dev->io_thread);
> > -
> > +       del_timer_sync(&dev->detect_timer);
> >         r592_enable_device(dev, false);
> >
> >         while (!error && dev->req) {
> > --
> > 2.25.1
> >

  reply	other threads:[~2023-03-10 16:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 16:43 [PATCH] memstick: r592: Fix UAF bug in r592_remove due to race condition Zheng Wang
2023-03-09 15:02 ` Ulf Hansson
2023-03-10 16:20   ` Zheng Hacker [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-03-07 16:42 Zheng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJedcCxrXuDjj_hGz7wizmfu1A9PNguNRNT85YVmkAHCG7ynYQ@mail.gmail.com \
    --to=hackerzheng666@gmail.com \
    --cc=1395428693sheep@gmail.com \
    --cc=alex000young@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=oakad@yahoo.com \
    --cc=ulf.hansson@linaro.org \
    --cc=zyytlz.wz@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).