From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E6A88565C for ; Tue, 19 Mar 2024 16:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710864843; cv=none; b=g6mkPO9HmF7DpEzPgnmBrgmEektetxszHau1k0vvhPUyar3vx+UP159TsH4P/1kIZAxaHaNgJ9/b+GvDFWj2FpcMybWbqW6Ps/1wpHVLZ2BG9MSiBBd78v94daCbvqpxyzRiYPT3H+smBG/6q1M3dy7p0wUaaTjG10QllMjnR0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710864843; c=relaxed/simple; bh=xK6oFtMSPOO/+MFMrzgdRfpeW/yJYOp63dnRub6XKM4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ciQ7VJdgbwgRdQx+D6ysbPnNO/XJyczAfUMUNLhWOgE0+fsA0tMODuunLMjSl5aCUVqaEXmbDOl4Kqc/xaUuHqjKkeoFvqH3wn7um1V47Rv/Kid/t3SarwA9r03kkkLvzPVpahCQOGDU7KhKl8vba50dQJ/ZIqmRyg7YiWeicJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szeredi.hu; spf=pass smtp.mailfrom=szeredi.hu; dkim=pass (1024-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b=l+V0fC34; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=szeredi.hu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=szeredi.hu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="l+V0fC34" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-56b9e5ed074so993303a12.3 for ; Tue, 19 Mar 2024 09:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1710864839; x=1711469639; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qssoFyi0EHVSMQZ8tvcNSLF8ll1cyBFfjAUL3WkFTKQ=; b=l+V0fC34qbWms3t2kAM2Tsaco+GNRpzk32yyo0NNeSGtZuo5iLyGwkDFxfHS7jyxuT EjYfJjUYY/jl10/fim6+6QLQfSlCeSzFvYZY0aAjsYBNlqdd16aIRTso+2GaFAMF86Wh g0+a6IL6vAXBN23hxZ4lFYPLWdEr8CCHoiv+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710864839; x=1711469639; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qssoFyi0EHVSMQZ8tvcNSLF8ll1cyBFfjAUL3WkFTKQ=; b=ZnILdYG4pIWN6tYkRavHk9b+8wB4zllzO5Ck29kJLHdqgjocDGwQgeOeTfdDlwgjJu BU/cl1gvhDZjGY5tJlMsK4snoyFHP/J/KMFKaUxxonXBgE45/T1cQ3kTi7ykCeJSzp7+ tqFbMWXO0FIf4U2HoxBZra83Z3/uzUysURFjYCH47vIjtknd1ouIVBNhKPFg4t006cx2 4LlXEjkJOChtC4OaTa5S19S3dInhgqX9Ad68xsH7gRBwDSC39nrGpE4np0ZmCNzu8sJE zHSar2XR0DigqXdMFU7SwmRvAu/OqugZ4q9d40MJWilLDdwStVB4y1tORWKNbaIdXkcp 1rRw== X-Forwarded-Encrypted: i=1; AJvYcCW564naZALjeDrL4oVBZ+cZyz/mk4g1oep6qx1FA4Fve6GTvlKtTEDzQ6/SYDsdgnUJBX21GXsGNfP949WmBo5gC+VCBWCBfhUwy17+ X-Gm-Message-State: AOJu0YxN9qepRJ/2b5jGq9PwWihDX8cGO2FjBrLDezTrercfSs0nrOcq HqjOBLLfBiGzAcdwhU4HqsWP+2NTXyyfSj90ZYSXgDe5UcfUnv8dG+Ga2WwAR1uARbawXsCKavl fy6TC8uxu9rZyyzkMzqY3osLnWIDwbiD0DqR6nA== X-Google-Smtp-Source: AGHT+IG80idJ/eoHfs/tS8xY4ItmYTZEjrCulMFp8PsOW5O33PBCGW/QH9XqH6EWMgC+d4lP/zrFK1SKGKNE4vf/7pM= X-Received: by 2002:a17:906:af07:b0:a46:47bc:580b with SMTP id lx7-20020a170906af0700b00a4647bc580bmr2203920ejb.56.1710864838625; Tue, 19 Mar 2024 09:13:58 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <1668172.1709764777@warthog.procyon.org.uk> <1831809.1709807788@warthog.procyon.org.uk> <651179.1710857687@warthog.procyon.org.uk> In-Reply-To: <651179.1710857687@warthog.procyon.org.uk> From: Miklos Szeredi Date: Tue, 19 Mar 2024 17:13:47 +0100 Message-ID: Subject: Re: [RFC PATCH] mm: Replace ->launder_folio() with flush and wait To: David Howells Cc: Matthew Wilcox , Trond Myklebust , Christoph Hellwig , Andrew Morton , Alexander Viro , Christian Brauner , Jeff Layton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Tue, 19 Mar 2024 at 15:15, David Howells wrote: > What particular usage case of invalidate_inode_pages2() are you thinking of? FUSE_NOTIFY_INVAL_INODE will trigger invalidate_inode_pages2_range() to clean up the cache. The server is free to discard writes resulting from this invalidation and delay reads in the region until the invalidation finishes. This would no longer work with your change, since the mapping could silently be reinstated between the writeback and the removal from the cache due to the page being unlocked/relocked. I'm not saying such a filesystem actually exists, but it's a theoretical possibility. And maybe there are cases which I haven't thought of. Thanks, Miklos