From: Miklos Szeredi <miklos@szeredi.hu>
To: Jan Kara <jack@suse.cz>
Cc: Amir Goldstein <amir73il@gmail.com>,
Eric Paris <eparis@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: fsnotify_mark_srcu wtf?
Date: Thu, 10 Nov 2016 21:44:36 +0100 [thread overview]
Message-ID: <CAJfpegsWcTz15gKOPXhDHyUviPuv59ypF=SDy7wTW1OqVfhGTw@mail.gmail.com> (raw)
In-Reply-To: <20161110194625.GG31098@quack2.suse.cz>
On Thu, Nov 10, 2016 at 8:46 PM, Jan Kara <jack@suse.cz> wrote:
> Except it doesn't quite work. We can pin the current marks by a refcount
> but they can still be removed from the list so after we regain srcu lock,
> we are not sure their ->next pointers still point to still allocated marks
> :-| Sadly I realized this only after implementing all this.
I think the real problem is the synchronous nature of the notification
interface, that really doesn't fit the permission events model very
well.
If it were to be changed around to an async interface then all the
marks could be iterated, the permission events queued and then the
srcu lock can be released for good.
Did I miss something?
Thanks,
Miklos
next prev parent reply other threads:[~2016-11-10 20:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 22:09 fsnotify_mark_srcu wtf? Miklos Szeredi
2016-11-03 10:25 ` Amir Goldstein
2016-11-05 21:43 ` Jan Kara
2016-11-05 21:34 ` Jan Kara
2016-11-06 6:45 ` Amir Goldstein
2016-11-09 11:10 ` Jan Kara
2016-11-09 18:26 ` Amir Goldstein
2016-11-10 19:46 ` Jan Kara
2016-11-10 20:02 ` Amir Goldstein
2016-11-10 20:44 ` Miklos Szeredi [this message]
2016-11-10 22:41 ` Amir Goldstein
2016-11-13 18:43 ` Amir Goldstein
2016-11-14 11:59 ` Amir Goldstein
2016-12-02 8:26 ` Miklos Szeredi
2016-12-02 10:48 ` Jan Kara
2016-12-02 11:02 ` Miklos Szeredi
2016-12-06 17:07 ` Jan Kara
2016-12-02 11:41 ` Amir Goldstein
2016-12-02 11:57 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegsWcTz15gKOPXhDHyUviPuv59ypF=SDy7wTW1OqVfhGTw@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=eparis@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).