From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310C5C71156 for ; Wed, 2 Dec 2020 16:19:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C35D72173E for ; Wed, 2 Dec 2020 16:19:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730725AbgLBQTh (ORCPT ); Wed, 2 Dec 2020 11:19:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730711AbgLBQTf (ORCPT ); Wed, 2 Dec 2020 11:19:35 -0500 Received: from mail-vk1-xa43.google.com (mail-vk1-xa43.google.com [IPv6:2607:f8b0:4864:20::a43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC892C0613D4 for ; Wed, 2 Dec 2020 08:18:55 -0800 (PST) Received: by mail-vk1-xa43.google.com with SMTP id s135so521157vkh.6 for ; Wed, 02 Dec 2020 08:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K37eg33TEYHBPIc9hdERySXaT7ddLk31VnYDOJlDBsg=; b=Qh43GnRo7YfF7QXgCietAKT8+vkZPBqYJF1+My0HDqIs9rZIo8YSN5dPnKbhJt35/O Bk92brV0mfpexLTOm4P1D2e/jzzHq0aEycI6SbiBHQ4W9TdRZzRMWRILKTnT50xTSA2i iPs17ztWvUY6GyDcrTIIhpbuNNzPUr9ojKwfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K37eg33TEYHBPIc9hdERySXaT7ddLk31VnYDOJlDBsg=; b=AUAH3Drcz+z0oGJZViNl4wZdSF6fJmS5vvSkrYPE4QshDGjtwN2XNFgbAtbftaFBbK 6b25se3CVW2U1iSpJz9LgL2s99/jvYgWu9sPP+HLMPQhlq3D2RaDFFJn6OmjEwE3BhnE 9Cg9AToyaD3V/nAyKRDLZE53Asq0SGk/Pbm/AT3zWR2UXjR/2z9USgiODTaPxC6g47VC KXrRMx1Txh7io5nBSVLoRVDAgpEeiZy5k3oyjIQ3vodvDiflhtmKRwdCCv/lzWOYzqbs 6AUendDdNwIdwOAz2bxWHE+u4EgpE/j2it45IZH79e+wYeQJg+ppVRADXDcSWmB5exJ0 t42g== X-Gm-Message-State: AOAM5305DRQ8Mxutmq19fIYV40GF9pSCRmTBslUs7Ux2YEkA+PM+e0sO XkOctIz8ugvElBsBs4wa1VXBZ1h2UW5qP/Kyns3ykA== X-Google-Smtp-Source: ABdhPJyTxGZ9z1k1i/Ix1wYvY05DOpOo2yBinjoa08BbT+ejSo+v8144fC3Nldom8dhjeZdLqBssK9ANee91fT78mH4= X-Received: by 2002:a1f:e7c2:: with SMTP id e185mr2204229vkh.23.1606925934724; Wed, 02 Dec 2020 08:18:54 -0800 (PST) MIME-Version: 1.0 References: <3e28d2c7-fbe5-298a-13ba-dcd8fd504666@redhat.com> <20201202160049.GD1447340@iweiny-DESK2.sc.intel.com> In-Reply-To: <20201202160049.GD1447340@iweiny-DESK2.sc.intel.com> From: Miklos Szeredi Date: Wed, 2 Dec 2020 17:18:43 +0100 Message-ID: Subject: Re: [PATCH V2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT To: Ira Weiny Cc: Eric Sandeen , Linus Torvalds , Miklos Szeredi , David Howells , linux-fsdevel@vger.kernel.org, linux-man , linux-kernel@vger.kernel.org, xfs , linux-ext4@vger.kernel.org, Xiaoli Feng Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 2, 2020 at 5:03 PM Ira Weiny wrote: > > On Tue, Dec 01, 2020 at 05:21:40PM -0600, Eric Sandeen wrote: > > [*] Note: This needs to be merged as soon as possible as it's introducing an incompatible UAPI change... > > > > STATX_ATTR_MOUNT_ROOT and STATX_ATTR_DAX got merged with the same value, > > so one of them needs fixing. Move STATX_ATTR_DAX. > > > > While we're in here, clarify the value-matching scheme for some of the > > attributes, and explain why the value for DAX does not match. > > > > Fixes: 80340fe3605c ("statx: add mount_root") > > Fixes: 712b2698e4c0 ("fs/stat: Define DAX statx attribute") > > Reported-by: David Howells > > Signed-off-by: Eric Sandeen > > Reviewed-by: David Howells > > Reviewed-by: Ira Weiny Stable cc also? Cc: # 5.8 Thanks, Miklos