From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936106Ab3DPRYb (ORCPT ); Tue, 16 Apr 2013 13:24:31 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:57253 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935825Ab3DPRYa (ORCPT ); Tue, 16 Apr 2013 13:24:30 -0400 MIME-Version: 1.0 X-Originating-IP: [188.6.195.195] In-Reply-To: References: <1366058481-21033-1-git-send-email-ccross@android.com> Date: Tue, 16 Apr 2013 19:24:28 +0200 Message-ID: Subject: Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set From: Miklos Szeredi To: Linus Torvalds Cc: Colin Cross , lkml , "open list:FUSE: FILESYSTEM..." , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 16, 2013 at 5:59 PM, Linus Torvalds wrote: > On Tue, Apr 16, 2013 at 7:21 AM, Miklos Szeredi wrote: >> >> And I still disagree. Why should userspace use the linux internal >> header when there's a perfectly good standard header that it can use? > > If it's called UAPI, it damn well is *meant* for user-space inclusion. > Look at the file-name. > > And since the bug comment says "This file defines the kernel interface > of FUSE" *AND* it very clearly has explicit code to support user-space > includes with special user-space-only type defines, then your email is > obviously just pure crap, and I don't understand how you can write > that sentence with a straight face. I think I meant something different by that sentence than what you think I meant :) What I meant is IF is included by userspace (it sure is meant to be included and *is* included by libfuse and other stuff) THEN using instead of is fine regardless of whether __linux__ is defined or not. Does that sound better, or is there still something we disagree about? Thanks, Miklos