From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE76AC433DB for ; Mon, 29 Mar 2021 09:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BE9C61969 for ; Mon, 29 Mar 2021 09:25:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231685AbhC2JYy (ORCPT ); Mon, 29 Mar 2021 05:24:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231522AbhC2JYl (ORCPT ); Mon, 29 Mar 2021 05:24:41 -0400 Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5AFAC061574 for ; Mon, 29 Mar 2021 02:24:41 -0700 (PDT) Received: by mail-vs1-xe35.google.com with SMTP id r12so2428368vsj.5 for ; Mon, 29 Mar 2021 02:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nUqVYbOsgzJvFaHO534MA1Tdm9chX2nN9+FCc/y44XE=; b=Guw+BOMais6EakAu9RohwYoxmmtYPJnwLs/4rXBB+5UKeB5Yk2UrYiXEwnNnkllavH gR+Ayxy4vd3HWHJa9R982DXzyD662Iha+wtjn3IWiK37BiidxzCx7+ACDI+z1HXLucj4 ajJUXlLUtrwguVPFucQuJIwHsRtyodYMdnz88= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nUqVYbOsgzJvFaHO534MA1Tdm9chX2nN9+FCc/y44XE=; b=AXNxrRxWFc/WiSF8eugJzXJhsib+jphdAACm/iReKxJOJ9AhreJ2WrCd+wwwbFXbzc Cppwiz6O1irLiqDV4M9hZ9gkpL/9vlHkR8Hgh8sNNj/+zf0Ud1Clr1h0+VnND5wJMVYh CoDqO5vyUE6rJYYFUY0LoHAsR789J95nB2tMhWt7D503LR97Njm69L89aFNHjrK4WFyD uIertphZo9foR/gxY1mfXmq5HyHjFyo5gFiosTdc0y7N5AnYHBsEQ0kS9Tgp3s3kEWDr VFOEkgxZkx83xIqwUo8CIqp3rYfYTwaqPahfvojgo0KorQ/E9MR5VgYkIGsc1Jo6t7Sg Rf3w== X-Gm-Message-State: AOAM530AA3BG2ZieTyrepwGLHzIqw/99HbC8/2kVShRNEEDwWZWpPwbQ 0qsnlxpf3YMhvfWdJ1+oJJRpyDtOhNCrett94XxLbA== X-Google-Smtp-Source: ABdhPJyZxxztIJkv/XIaxwQ8J2HG8Af2Yj5L8n64NOybPY5kHyelQ8Yf6zkuJ1gUrjuqCaWQkxiofplCj62NVVMbq+g= X-Received: by 2002:a67:63c5:: with SMTP id x188mr1682420vsb.9.1617009880930; Mon, 29 Mar 2021 02:24:40 -0700 (PDT) MIME-Version: 1.0 References: <20210325193755.294925-1-mszeredi@redhat.com> <20210325193755.294925-4-mszeredi@redhat.com> In-Reply-To: From: Miklos Szeredi Date: Mon, 29 Mar 2021 11:24:30 +0200 Message-ID: Subject: Re: [PATCH v3 03/18] ovl: stack fileattr ops To: Al Viro Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 28, 2021 at 8:09 PM Al Viro wrote: > > On Thu, Mar 25, 2021 at 08:37:40PM +0100, Miklos Szeredi wrote: > > Add stacking for the fileattr operations. > > > > Add hack for calling security_file_ioctl() for now. Probably better to > > have a pair of specific hooks for these operations. > > Umm... Shouldn't you remove the old code from their ->ioctl() instance? Will do, once fuse gets converted. And fuse will get converted, when I manage to decide on the best way to do it: 1) keep a list of open files for each inode, pick random one for doing the ioctl (really shouldn't matter which one) 2) do a sequence of open - [sg]et attr - release for each invocation Thanks, Miklos