From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E9AC433B4 for ; Tue, 13 Apr 2021 14:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19CDD60551 for ; Tue, 13 Apr 2021 14:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238492AbhDMOxi (ORCPT ); Tue, 13 Apr 2021 10:53:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbhDMOxf (ORCPT ); Tue, 13 Apr 2021 10:53:35 -0400 Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92B92C061756 for ; Tue, 13 Apr 2021 07:53:14 -0700 (PDT) Received: by mail-vs1-xe35.google.com with SMTP id g20so8673482vst.2 for ; Tue, 13 Apr 2021 07:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qpBExCiZQlQf9v/ukxaQqC4noDhKnFApocLLkZan05g=; b=AE4Kwg+qjn9BXqj7AtlOnUMIVDmSIf4+8RPHjDrL+7Q4/2FPFk43jr0ryh2SJNewX1 gTbWtTgr39JeqZL/27PXabWcuKZJyrVbY0aSrg5d6oWcYZLOqgYfcGBA9GD3yE+24FEk bJ524/31JiGvNYqcBZczVB8JHF8Sg+I/h6nMw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qpBExCiZQlQf9v/ukxaQqC4noDhKnFApocLLkZan05g=; b=OtEQUhtFHLUkgvuZkBxEscxdf5BTQLnekRLKUvZhHLA51fdTGP6JKqeyhDa8fV3tcM Y6AI+LP6laAbMmoQHaYQcPSa0gr3Yj8XXmWStDLk++o7Py6UjaYt7pK1czoqoyv62VRX alYauFHEnYoQ/NMehuRj6Hrx0IN8fhp4OgXPt7x/il3x0P58bu9i/FOI0V6y2Vof7GJe WeMDtHTux5ilcKKSGiK6wMW1MaaxIo8wZHzVlEuSLy5kboomXxmsZcPAzIzilhdiZzOu z1Dp2+IrN9fAJJJCE3DFyRaq0+5f3lhFininlY1Oc8X/o3+GcI1ya6VJ7AUS4wKZiSmC QA5A== X-Gm-Message-State: AOAM533p7yksQDNNJ4f0xBkLgkPCQeZI+eYYYhjdPNQ5/4iV4FJijd3s 8UKxRI9AViX3aVk55Y12txzgR+8xKbSNsux5uO3cXA== X-Google-Smtp-Source: ABdhPJyK2wmF7sCncs1jt4t34+HmKqjg4ZPOu8kXNhYBq0UbUb8sg4DuOIarkxF7MP9BTwZkLJ2j+MD8Qa99ScQ6+5M= X-Received: by 2002:a67:6647:: with SMTP id a68mr21372885vsc.21.1618325592663; Tue, 13 Apr 2021 07:53:12 -0700 (PDT) MIME-Version: 1.0 References: <20210325193755.294925-1-mszeredi@redhat.com> <20210325193755.294925-2-mszeredi@redhat.com> <20210413144502.GP2531743@casper.infradead.org> In-Reply-To: <20210413144502.GP2531743@casper.infradead.org> From: Miklos Szeredi Date: Tue, 13 Apr 2021 16:53:01 +0200 Message-ID: Subject: Re: [PATCH v3 01/18] vfs: add fileattr ops To: Matthew Wilcox Cc: Miklos Szeredi , linux-fsdevel@vger.kernel.org, Al Viro , "Darrick J . Wong" , Amir Goldstein , David Sterba , Christian Brauner , Eric Biggers , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 4:46 PM Matthew Wilcox wrote: > > On Thu, Mar 25, 2021 at 08:37:38PM +0100, Miklos Szeredi wrote: > > @@ -107,6 +110,8 @@ fiemap: no > > update_time: no > > atomic_open: shared (exclusive if O_CREAT is set in open flags) > > tmpfile: no > > +fileattr_get: no or exclusive > > +fileattr_set: exclusive > > ============ ============================================= > > This introduces a warning to `make htmldocs`: > > /home/willy/kernel/folio/Documentation/filesystems/locking.rst:113: WARNING: Malformed table. > Text in column margin in table line 24. > > You need to add an extra '=' to the first batch of '=' (on all three lines of > the table). Like this: Yep, already fixed in #fileattr_v6, which I asked Al to pull. Thanks, Miklos