From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C6DC433F5 for ; Tue, 10 May 2022 13:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243714AbiEJNgE (ORCPT ); Tue, 10 May 2022 09:36:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243095AbiEJNZa (ORCPT ); Tue, 10 May 2022 09:25:30 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1327197F66 for ; Tue, 10 May 2022 06:18:53 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id z19so19976978edx.9 for ; Tue, 10 May 2022 06:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bQPxzjuthC5W7FG0xtvK97qut8WhgOZVs5QGqQcukzE=; b=Ib9QQhXrM+AZHVuN39H0Gj+04jz1DkFcq6dfa7Ts+bfu4GOpgy7EP6e6+/Bu+c3z2N ENIb0CkTl5epcS7kuHzNgbY6Ckx3XymenJ9LEcP3JjqiswNfAYZSUESSCTojwaYl0Ys8 Wby5SNlVrBFWql2lFfQTzdFuqaK5lVdg5fmGk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bQPxzjuthC5W7FG0xtvK97qut8WhgOZVs5QGqQcukzE=; b=WOqC8auErpCAgK/SLj4tLXCKBikW7jcingNuoEzquqj93uuPQsBqqgAvjYZzaMSLoh 42YXJ6LItCJ0FRXon7Uhpw36cWhkmnZDaeD56JQ/ZIT6pOTzaiMxVumUSk0hWJ0iPyug RoPMUV/9d2NiS2L2a7rKPPHuFyL2lPi2g5Dc6LSBcjoZ3D42Lvkg64U3Ixam8npXy/TQ f3IRyTWfOHjkjIOLx2tdfAqLGJbLceuVg+TW3GVjCUPs9uaNqvYH0iZBpi7G+wbwT0Uo RTCS1wBRExNGyi8p7anA6Ynp2zwwZJsiBQnU+AcQuhKuEnt/RLNWFSpPZIPtfVFm8uEG boNw== X-Gm-Message-State: AOAM531C8yQCfUvg0atVwZ0LbNzFH/S538EEcqj8TFblZIV1Q0ytoLxn R68trcyHcfjOtaV1vEFOJVi3FeZYAirkBkXKKsmArA== X-Google-Smtp-Source: ABdhPJwczgUPDxe7i5EFoi7djB0qfa6gmDtEieMpp4Tpi/GlN71wFMNkosjsi+Nmytcb6euO0hRwtO0GNWPw30McobE= X-Received: by 2002:a05:6402:f08:b0:428:53c1:a867 with SMTP id i8-20020a0564020f0800b0042853c1a867mr23374997eda.224.1652188732583; Tue, 10 May 2022 06:18:52 -0700 (PDT) MIME-Version: 1.0 References: <20220509124815.vb7d2xj5idhb2wq6@wittgenstein> <20220510115316.acr6gl5ayqszada6@wittgenstein> In-Reply-To: From: Miklos Szeredi Date: Tue, 10 May 2022 15:18:40 +0200 Message-ID: Subject: Re: [RFC PATCH] getting misc stats/attributes via xattr API To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Dave Chinner , "Theodore Ts'o" , Karel Zak , Greg KH , linux-kernel@vger.kernel.org, Linux API , linux-man , LSM , Ian Kent , David Howells , Linus Torvalds , Al Viro , Christian Brauner , Amir Goldstein , James Bottomley Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 May 2022 at 15:15, Miklos Szeredi wrote: > > On Tue, 10 May 2022 at 13:53, Christian Brauner wrote: > > > > What exactly are the attributes that systemd requires? > > > > We keep a repo with ideas for (kernel) extensions - we should probably > > publish that somewhere - but the list we used for a prototype roughly > > contains: > > > > * mount flags MOUNT_ATTR_RDONLY etc. > > * time flags MOUNT_ATTR_RELATIME etc. (could probably be combined with > > mount flags. We missed the opportunity to make them proper enums > > separate from other mount flags imho.) > > * propagation "flags" (MS_SHARED) > > * peer group > > * mnt_id of the mount > > * mnt_id of the mount's parent > > * owning userns > > Sounds good thus far. And hey, we don't even need a new syscall: > statx(2) could handle these fine. Oh, we need this indexed with a mount id, which statx can't do. So indeed, a new syscall may be the best choice. Thanks, Miklos