From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D12B8C433E0 for ; Mon, 15 Jun 2020 22:38:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4890207DD for ; Mon, 15 Jun 2020 22:38:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X3FDwr9n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726529AbgFOWiU (ORCPT ); Mon, 15 Jun 2020 18:38:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbgFOWiT (ORCPT ); Mon, 15 Jun 2020 18:38:19 -0400 Received: from mail-vs1-xe43.google.com (mail-vs1-xe43.google.com [IPv6:2607:f8b0:4864:20::e43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6DE6C061A0E for ; Mon, 15 Jun 2020 15:38:19 -0700 (PDT) Received: by mail-vs1-xe43.google.com with SMTP id q2so10334425vsr.1 for ; Mon, 15 Jun 2020 15:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uB0HaPwXy50jpF9rLf6Va8RuH3FYVyhSdvvt08br5zU=; b=X3FDwr9nZuJCmTh8GMOnY3FLyA7+HVUEP8pR16yq4aXwBt2APUy+WQlUH7WXO0w1yO K9as3TCf0flU3QG2pe9+qgtngay4G9A79ycQaoQ4ShA7R+KHuuMILpAkdyspjt4fvz6b 6DskIBmOoDOnE5ANKPtw3rJuuPoEMNorRI16aJuahLNR+o/RI1Ik23dHdVKZ53W8GhiO J1khFgOVTEgwxS3L+AUhna+J37YyTVU2rP6BqVu+sLwyJQw2uq4WV6kfNIneyfyzlld3 1owtRTKd697eSOPCJApkFir0AjBBvikH2FdzrTguRztSShfhAO2U/NyeEMkDfaUHROTb wA+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uB0HaPwXy50jpF9rLf6Va8RuH3FYVyhSdvvt08br5zU=; b=nVr5GvlTnoZvgdUbn4OK15Ne+Gnd7OxHUq9g+uC0wF2RTTrY65FSGTrXtzur1/OLDz FwwpDUNZLkl79viQkMjjHXCUt6ih+hXN0YJu6839PZvH7DDXDj0sZRAM5HXoSSrJOHV/ hFBBE1YlyV+3FRdFZrHm4NePA4+Z/CLRcmBndvsJ2mSmXmVm4pmobwit8wRTuIiYncf4 y4mSBHari6ERTeuCd9sITmdSM5Waw1N5qJQ29QSzEW5q+0wUtCh1ginFJdpfggdauUdK 8v0PqwD+S/tDHsVUhi0lz8PSna5eg3ok7p0tWeUI9gg9wmyQKdW++APvR55oKPdmNMKe sRPQ== X-Gm-Message-State: AOAM5305QCOv2noHakbumez7IC/rw/2VZAF1t6YkhXp+FheutjSu1Hy8 r3YzZdmIYcVEpHKiVF4JdqcGMF6qlE7i1mDtR2c= X-Google-Smtp-Source: ABdhPJyqW3jvG9hiix79BPnCB5e/t/YfkMU4SWUOaw1QLk2myo2b7g+Q0rTbLC0jk3VQQRfnIaMWXgzp6zg1dAxZEDU= X-Received: by 2002:a67:c511:: with SMTP id e17mr20082140vsk.210.1592260698905; Mon, 15 Jun 2020 15:38:18 -0700 (PDT) MIME-Version: 1.0 References: <20200613155738.2249399-1-jim.cromie@gmail.com> <20200613155738.2249399-11-jim.cromie@gmail.com> <20200615133740.GG31238@alley> In-Reply-To: <20200615133740.GG31238@alley> From: jim.cromie@gmail.com Date: Mon, 15 Jun 2020 16:37:52 -0600 Message-ID: Subject: Re: [PATCH v2 10/24] dyndbg: refactor parse_linerange out of ddebug_parse_query To: Petr Mladek Cc: Jason Baron , LKML , akpm@linuxfoundation.org, Greg KH , Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2020 at 7:37 AM Petr Mladek wrote: > > On Sat 2020-06-13 09:57:24, Jim Cromie wrote: > > make the code-block reusable to later handle "file foo.c:101-200" etc. > > > This should be a 90%+ code-move, with minimal adaptations; reindent, > > and scafolding. > > This sentence sounds like the author did some hidden > microoptimizations and potentially broke the code. > It made me nervous. > > But in fact, I do not see any real change except that the variable > "first" does not longer need to be defined. So, it is just a code move. > > In this case, I usually write: > > This patch does not change the existing behavior. I see your point. it was code move, reindent, add function wrapper, add call, compile I just dont recall if I had to touch anything else, add/move var decls etc.