From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0933C11F65 for ; Wed, 30 Jun 2021 16:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E31861456 for ; Wed, 30 Jun 2021 16:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231536AbhF3Ql6 (ORCPT ); Wed, 30 Jun 2021 12:41:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbhF3Ql4 (ORCPT ); Wed, 30 Jun 2021 12:41:56 -0400 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3E30C061756 for ; Wed, 30 Jun 2021 09:39:25 -0700 (PDT) Received: by mail-vs1-xe33.google.com with SMTP id l68so2031560vsc.13 for ; Wed, 30 Jun 2021 09:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X8gMFR1A10s93xV07w9I9Oq+Pgqfmx7L44pDnudkZFA=; b=kyINrnqN2yjb2P6g6motDjhmZsGqJFUV3IeXvsT7i1IZv9rl3FDzFerFczudKUnTLs uZLcP1C65vjNKvonSs4UjrXkYYBnEnCHWSVPJuiP2vR8P5y+NLHtYaERFSOtEWtk74Ze SbDW4XfLi9TdDzBzdsLTUkoGhvQRYK9I7PSAW4BiigaMDgslROT9hC9KowrYSOCw3+lY HJZtwu65cWkso/DawhwSKPtmod79eqNFswuWWfHLJ46T4nz64rt/Fppa6gYtYHBkLVp1 yNF5C/Xh5Lw7Byw3bHggwttC8ojcsdIQC0pTpuIqlyL7jRc4JdjfDRRi8jNrjPNWSetj j2Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X8gMFR1A10s93xV07w9I9Oq+Pgqfmx7L44pDnudkZFA=; b=UibPlzpr47+0Ukw1sYiwHuHBVN5g30q7XyKwLxe9gvxXICpX+k+uLcyAYvY/OZmrOU B1xEe3sXXaokt3y5WxIqRE1ionSB4FPrHBtIqexmxfdxCflwxiq+WB4LQ6wBfzUxN/k2 lKdrmdipTKHM+f9oNHBON8AldGTDbhU01VDLWqp+JeKhCK84ZAaYC0NSGmSVOVQTpT2/ DM4vYWpfVSDApFypNQJGIy/L6GLjK2nfc3XV7ObB++nAkfV0ufsCZMhVWWBRThbCbw8w YcJsdAGkYw7+jxPq2nb8uAxApQnDhRaF1NhJGg6h9GyF9wKcDIvowygaEL/YqPMRLzZq E1jQ== X-Gm-Message-State: AOAM531L4qtd5wgyV+HrXg1JMAYLIsx43nGfWhMgn30PVXqRf8BTSgK3 cCx67eM9ls8jrHZdsB4Do86oplCud+momnDR5ag= X-Google-Smtp-Source: ABdhPJzdJ9VKed8h0Ud9H9jMmx7kuO1jz6IclgxpnhqcaKwsaFOT7+ldUbWkxYm/Rywd3jPV4hOBPuL/wHosCPb526Q= X-Received: by 2002:a05:6102:732:: with SMTP id u18mr31616335vsg.14.1625071165063; Wed, 30 Jun 2021 09:39:25 -0700 (PDT) MIME-Version: 1.0 References: <20210626034016.170306-1-jim.cromie@gmail.com> <20210626034016.170306-2-jim.cromie@gmail.com> <075e07c40b99f93123051ef8833612bc88a55120.camel@perches.com> <5d28704b131e375347f266b10fc54891ba2a4fc4.camel@perches.com> In-Reply-To: From: jim.cromie@gmail.com Date: Wed, 30 Jun 2021 10:38:57 -0600 Message-ID: Subject: Re: [PATCH 1/3] checkpatch: skip spacing tests on linker scripts To: Joe Perches Cc: LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 29, 2021 at 2:01 PM Joe Perches wrote: > > On Tue, 2021-06-29 at 13:50 -0600, jim.cromie@gmail.com wrote: > > this does 3 different things > > > > - non-capturing matches - these add no functionality, > > true, it's nominally a bit faster through. > > > - moves the skip-remaining-tests check after SPDX > > that feels like a legal Q: should it be on all files ? > > moving it does seem proper though. > > to me too. > > > - adds the skip linker-script > > since i went ahead and added it 3 times to see errs/warns > > I didnt consider your precise placement, > > how does it do with 18/8 errs/warnings on ref-test ? > > $ ./scripts/checkpatch.pl -f include/asm-generic/vmlinux.lds.h --strict --terse cool options.