From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51BD3C4320A for ; Mon, 2 Aug 2021 18:41:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31B9D60EC0 for ; Mon, 2 Aug 2021 18:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229719AbhHBSlL (ORCPT ); Mon, 2 Aug 2021 14:41:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbhHBSlK (ORCPT ); Mon, 2 Aug 2021 14:41:10 -0400 Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF967C06175F for ; Mon, 2 Aug 2021 11:40:59 -0700 (PDT) Received: by mail-vs1-xe29.google.com with SMTP id e4so10032820vsr.13 for ; Mon, 02 Aug 2021 11:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/JDTciPhpsppEZzll6/Pi+0di+r/qXoRaAHXje8rJcU=; b=S3aODv0PgPYOT/8F/bbj3dquc+grd5ZpsnpETdDqus+QDd2kunXjqcW/H3wovrtZ7U +p/U+UlX4tS+va3Vh4kEG1jnTdJm/dSxz2OKt0fiETASvNNpHjkhhOtNzXlyK8DLN12v kS3rjNgLkrexKp6uqhITyyaNgkWIJlivez5QIAA98ltBCV/OXBpgtJOMZppFm5RyK7Jt 7nRy1cd1pCvjH1FzxVDLnu4OLtlg+LuAbmUwgY9uWq6zgsay/t2dSTyJCw0No+lgsGBp zge03tBYC1O8JzoQev7AiQ9oBKwUCI8SQQ5TcoQRjvuqMJ8DWuwlUJnh8vyqHjkCog1v BPXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/JDTciPhpsppEZzll6/Pi+0di+r/qXoRaAHXje8rJcU=; b=gHIFTIQyT6Cpt0rtq96N9ibdsh+UwOCjWeP2N+F2fLZvcNJ9tc1+iId/xVLmV2hloX sFryoPnoVsD6o0dWLG9H4GnZcw7+zzEiUBCIrsgPp6avQ7vhQN/Ttyt+0gBJ+SlnrRwV aFcUaBT8FiL3AZ0f0PATXb+A5wLFQZU22zDNZce/5cPjaHvNVe3FSi5somSiIyzC+Ll3 +hQccW8WRWQQHTXdWjOxjouPU/hmeJpfyO0V9Swl1lC6hx2T5on95jpokcLbgEe5Unhq BsV5paWtOr45XjT7RXxQP9ohnxqX6KZD0BMrNxOsWlHp+t9irP30qSOwInWT5GsR4VuD GIfQ== X-Gm-Message-State: AOAM533tHfL0VugkcwWtyABGr7nAJQ5zsLvtuqM2eRH5SSfH925NkoU3 oXPlJCigfjxeADqniS7n7mY+UVoWwKYdqTVjq3k= X-Google-Smtp-Source: ABdhPJzaPWXcRFrinBModzRbebP+orB2U9FIw0YukoKvhxHaw/U/+j7xcsCnnRbrJfcujheOgU/OYeK28C0hEWg237I= X-Received: by 2002:a05:6102:2325:: with SMTP id b5mr7459900vsa.56.1627929658962; Mon, 02 Aug 2021 11:40:58 -0700 (PDT) MIME-Version: 1.0 References: <20210731214211.657280-1-jim.cromie@gmail.com> <20210731214211.657280-4-jim.cromie@gmail.com> In-Reply-To: From: jim.cromie@gmail.com Date: Mon, 2 Aug 2021 12:40:32 -0600 Message-ID: Subject: Re: [Intel-gfx] [PATCH v4 3/7] dyndbg: add dyndbg-bitmap definer and callbacks To: Emil Velikov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Jason Baron , Ashley Thomas , Qingqing Zhuo , Aurabindo Pillai , Wyatt Wood , Johan Hovold , Jessica Yu , Joe Perches , Miguel Ojeda , Nick Desaulniers , ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" , amd-gfx mailing list , intel-gvt-dev@lists.freedesktop.org, Intel Graphics Development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 2, 2021 at 10:24 AM Emil Velikov wrote: > > Hi Jim, > > On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote: > > > +struct dyndbg_bitdesc { > > + /* bitpos is inferred from index in containing array */ > > + char *prefix; > > + char *help; > AFAICT these two should also be constant, right? > > > > +int param_set_dyndbg(const char *instr, const struct kernel_param *kp) > > +{ > > + unsigned int val; > > + unsigned long changes, result; > > + int rc, chgct = 0, totct = 0, bitpos, bitsmax; > > + char query[OUR_QUERY_SIZE]; > > + struct dyndbg_bitdesc *bitmap = (struct dyndbg_bitdesc *) kp->data; > > + > > + // pr_info("set_dyndbg: instr: %s curr: %d\n", instr, *kp->arg); > Left-over debug code, here and below? yup, all fixed up locally, with a version that fully works. thanks. > > -Emil