From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1469BC4338F for ; Mon, 2 Aug 2021 18:37:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8A126112F for ; Mon, 2 Aug 2021 18:37:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbhHBShT (ORCPT ); Mon, 2 Aug 2021 14:37:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbhHBShR (ORCPT ); Mon, 2 Aug 2021 14:37:17 -0400 Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37866C06175F for ; Mon, 2 Aug 2021 11:37:07 -0700 (PDT) Received: by mail-vs1-xe34.google.com with SMTP id k24so2060008vsg.9 for ; Mon, 02 Aug 2021 11:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IpKyihB3M+3oinMY5i464lWGHngiMrlvZE39L5yuKac=; b=IELFFR56N8LyPmwrNGKlS1ao8vH/LLrw5ZS44V5f8D3W1JRnUh+LPgTzqBlU8FgoE8 fGGimjIp5iIsWIAIkJ35I5YGoLfKQoJrxQZRnTaj/YUANaLxOODm961BVRPP4fr6h7k3 CwtQLVbWYB0iEirh0GGxW+0thmIhG5wHoASQX/luG9Xj+JsIr/NssxM5XxQ0PrkJM11A 2VJEKixVg6QFXFzsBqsqNM2funSFiKMT3NRmOmn5alXZcLarqoL7QOcIZgGjCIV5Qene Z65cCkyLEtI5gkfeNntJ6lCMBvHJmtCe171UlD+regWNlwSnh0iE/oXwKOxH4IoM5hKm 8wtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IpKyihB3M+3oinMY5i464lWGHngiMrlvZE39L5yuKac=; b=oWspvbXZOAZtcG446Wh/pLzF7EazCmxMwucvXqay9gKjb11Oke5o9YrsxKkYUkVqIV t4Gd+fCIQ1elr5Ysu9XEcWe8+L2eyJHrgcexHRfeA0+F14sINBLh/uaHmeg3UtLJ11pi Nq8ptGyjSN6qFYEmTgpdN2VxTy3T4ZUL0oct7YU4QGneFriuP15uo4/K/mk9EdvjKjwC fud4ZBnk82fT01xdGtp4358wHJ83eVYKxOGulNdRG3o3q1Us2/cARN2zzJDQrrrdmrEc p0dCtTFY8b4Fst8TdCIu9cAUApvOGZYQZehICXOR+zwv0ke3VbAu9IYfiARSjkqkdY/A mlJQ== X-Gm-Message-State: AOAM530ZpasdeqmATMU3oKUKx+jKzZm9EUcfTbtuxBcXS46foMsr8BFc XAOBCXxTPjPoLPQJiAlL1AkXrILC6oztsOhl8jM= X-Google-Smtp-Source: ABdhPJzjo/9qOXG0fdeyFyvhz+Aj/p8NcNMo/+WII7wlKLWCAd3lrkIimR0VXnppY4xXe7pst3ulKKdyrBotgKBzXac= X-Received: by 2002:a67:f58c:: with SMTP id i12mr1373736vso.7.1627929426283; Mon, 02 Aug 2021 11:37:06 -0700 (PDT) MIME-Version: 1.0 References: <20210731214211.657280-1-jim.cromie@gmail.com> <20210731214211.657280-3-jim.cromie@gmail.com> In-Reply-To: From: jim.cromie@gmail.com Date: Mon, 2 Aug 2021 12:36:39 -0600 Message-ID: Subject: Re: [PATCH v4 2/7] moduleparam: add data member to struct kernel_param To: Emil Velikov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Jason Baron , Ashley Thomas , Aurabindo Pillai , Qingqing Zhuo , Wyatt Wood , Jessica Yu , Johan Hovold , Joe Perches , Miguel Ojeda , Nick Desaulniers , ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" , amd-gfx mailing list , intel-gvt-dev@lists.freedesktop.org, Intel Graphics Development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 2, 2021 at 10:18 AM Emil Velikov wrote: > > Hi Jim, > > On Sat, 31 Jul 2021 at 22:42, Jim Cromie wrote: > > > Use of this new data member will be rare, it might be worth redoing > > this as a separate/sub-type to keep the base case. > > > > Signed-off-by: Jim Cromie > > --- > > include/linux/moduleparam.h | 11 +++++++++-- > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h > > index eed280fae433..e9495b1e794d 100644 > > --- a/include/linux/moduleparam.h > > +++ b/include/linux/moduleparam.h > > @@ -78,6 +78,7 @@ struct kernel_param { > > const struct kparam_string *str; > > const struct kparam_array *arr; > > }; > > + void *data; > > Might as well make this "const void *" since it is a compile-time constant? > yes indeed. revising. thanks > -Emil