Re: [PATCH 02/10] dynamic_debug: Consolidate prefix output to single routine

[Jim Cromie <jim.cromie@gmail.com>]

On Thu, Jul 7, 2011 at 12:14 PM, Bart Van Assche <bvanassche@acm.org> wrote:
> On Wed, Jul 6, 2011 at 7:24 PM, Jason Baron <jbaron@redhat.com> wrote:
>>
>> From: Joe Perches <joe@perches.com>
>>
>> Adding dynamic_dev_dbg duplicated prefix output.
>> Consolidate that output to a single routine.
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>> Signed-off-by: Jason Baron <jbaron@redhat.com>
>> ---
>>  lib/dynamic_debug.c |   38 ++++++++++++++++++--------------------
>>  1 files changed, 18 insertions(+), 20 deletions(-)
>>
>> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
>> index 5c5f8f9..758e922 100644
>> --- a/lib/dynamic_debug.c
>> +++ b/lib/dynamic_debug.c
>> @@ -428,15 +428,10 @@ static int ddebug_exec_query(char *query_string)
>>        return 0;
>>  }
>>
>> -int __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...)
>> +static int dynamic_emit_prefix(const struct _ddebug *descriptor)
>>  {
>
> How about renaming dynamic_emit_prefix() into ddebug_emit_prefix() ?
> Personally I prefer the latter name over the former.
>
> Bart.
>

WRT naming, Id like dyndbg, esp as exposed on kernel cmdline, parameters..

dyndbg.query=....
dyndbg.verbose=1
/sys/modules/dyndbg/parameters/verbose

does this run up against ABI issues ?