From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752136AbdLBBGc (ORCPT <rfc822;w@1wt.eu>);
        Fri, 1 Dec 2017 20:06:32 -0500
Received: from mail-io0-f194.google.com ([209.85.223.194]:33621 "EHLO
        mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751859AbdLBBGa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Dec 2017 20:06:30 -0500
X-Google-Smtp-Source: AGs4zMah+2/V3DGu7fP3zU25TuE+EHHGba2QGXSpWMl0QSdwJBCt6lP/dtrnO0zCXuNVrlXaXZGyk/ya960fVYUq2BU=
MIME-Version: 1.0
In-Reply-To: <1512156104-20104-5-git-send-email-paulmck@linux.vnet.ibm.com>
References: <20171201192122.GA19301@linux.vnet.ibm.com> <1512156104-20104-5-git-send-email-paulmck@linux.vnet.ibm.com>
From: Lai Jiangshan <jiangshanlai@gmail.com>
Date: Sat, 2 Dec 2017 09:06:29 +0800
Message-ID: <CAJhGHyB00TXQfYh08cztdgHPPYr9t_Frcthi4ooWB9aQ2kvqRQ@mail.gmail.com>
Subject: Re: [PATCH tip/core/rcu 05/10] workqueue: Eliminate
 cond_resched_rcu_qs() in favor of cond_resched()
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        dipankar@in.ibm.com, akpm@linux-foundation.org,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        David Howells <dhowells@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        =?UTF-8?B?RnLDqWTDqXJpYyBXZWlzYmVja2Vy?= <fweisbec@gmail.com>,
        oleg@redhat.com, Tejun Heo <tj@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 2, 2017 at 3:21 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> Now that cond_resched() also provides RCU quiescent states when
> needed, it can be used in place of cond_resched_rcu_qs().  This
> commit therefore makes this change.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>

Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>

> ---
>  kernel/workqueue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 8fdb710bfdd7..aee7eaab05cb 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -2135,7 +2135,7 @@ __acquires(&pool->lock)
>          * stop_machine. At the same time, report a quiescent RCU state so
>          * the same condition doesn't freeze RCU.
>          */
> -       cond_resched_rcu_qs();
> +       cond_resched();
>
>         spin_lock_irq(&pool->lock);
>
> --
> 2.5.2
>