linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	dipankar@in.ibm.com, akpm@linux-foundation.org,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Josh Triplett" <josh@joshtriplett.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"David Howells" <dhowells@redhat.com>,
	"Eric Dumazet" <edumazet@google.com>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	oleg@redhat.com
Subject: Re: [PATCH tip/core/rcu 2/6] srcu: Change printk() %p to %pK
Date: Sat, 2 Dec 2017 09:27:46 +0800	[thread overview]
Message-ID: <CAJhGHyC_U431HwtmW2GN76bDqy2DiwyQ+j3NDWB9KaSyYj-c0A@mail.gmail.com> (raw)
In-Reply-To: <1512157320-23205-2-git-send-email-paulmck@linux.vnet.ibm.com>

On Sat, Dec 2, 2017 at 3:41 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> This commit changes the %p printk() in rcutorture to %pK.  This could
> be considered irrelevant, given that any user able to start rcutorture
> could inflict far heavier damage on the system, but it doesn't hurt to
> change it and doing so avoids script-generated noise.
>
> Reported-by: Tobin C. Harding <me@tobin.cc>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>

> ---
>  kernel/rcu/srcutree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index d5cea81378cc..81f2eb78c504 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -386,7 +386,7 @@ void cleanup_srcu_struct(struct srcu_struct *sp)
>                 flush_delayed_work(&per_cpu_ptr(sp->sda, cpu)->work);
>         if (WARN_ON(rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)) != SRCU_STATE_IDLE) ||
>             WARN_ON(srcu_readers_active(sp))) {
> -               pr_info("cleanup_srcu_struct: Active srcu_struct %p state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)));
> +               pr_info("cleanup_srcu_struct: Active srcu_struct %pK state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)));
>                 return; /* Caller forgot to stop doing call_srcu()? */
>         }
>         free_percpu(sp->sda);
> --
> 2.5.2
>

  reply	other threads:[~2017-12-02  1:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 19:41 [PATCH tip/core/rcu 0/6] Miscellaneous fixes for v4.16 Paul E. McKenney
2017-12-01 19:41 ` [PATCH tip/core/rcu 1/6] srcu: Prohibit call_srcu() use under raw spinlocks Paul E. McKenney
2017-12-01 19:41 ` [PATCH tip/core/rcu 2/6] srcu: Change printk() %p to %pK Paul E. McKenney
2017-12-02  1:27   ` Lai Jiangshan [this message]
2017-12-04 18:31     ` Paul E. McKenney
2017-12-01 19:41 ` [PATCH tip/core/rcu 3/6] rcu: " Paul E. McKenney
2017-12-01 19:41 ` [PATCH tip/core/rcu 4/6] tracing, rcu: Hide trace event rcu_nocb_wake when not used Paul E. McKenney
2017-12-01 19:41 ` [PATCH tip/core/rcu 5/6] rcu: Add comment giving debug strategy for double call_rcu() Paul E. McKenney
2017-12-01 19:42 ` [PATCH tip/core/rcu 6/6] rcu: Remove have_rcu_nocb_mask from tree_plugin.h Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJhGHyC_U431HwtmW2GN76bDqy2DiwyQ+j3NDWB9KaSyYj-c0A@mail.gmail.com \
    --to=jiangshanlai@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).