From: Lai Jiangshan <jiangshanlai@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kvm x86/mmu: use KVM_REQ_MMU_SYNC to sync when needed
Date: Fri, 28 Aug 2020 09:47:22 +0800 [thread overview]
Message-ID: <CAJhGHyDuS27+uPbqvc3Bn4aY_ncUAQo4AA_tRDZXQms-Y=r6LQ@mail.gmail.com> (raw)
In-Reply-To: <20200824101825.4106-1-jiangshanlai@gmail.com>
Ping @Sean Christopherson
On Mon, Aug 24, 2020 at 5:18 PM Lai Jiangshan <jiangshanlai@gmail.com> wrote:
>
> From: Lai Jiangshan <laijs@linux.alibaba.com>
>
> 8c8560b83390("KVM: x86/mmu: Use KVM_REQ_TLB_FLUSH_CURRENT for MMU specific flushes)
> changed it without giving any reason in the changelog.
>
> In theory, the syncing is needed, and need to be fixed by reverting
> this part of change.
>
> Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
> ---
> arch/x86/kvm/mmu/mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index 4e03841f053d..9a93de921f2b 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -2468,7 +2468,7 @@ static struct kvm_mmu_page *kvm_mmu_get_page(struct kvm_vcpu *vcpu,
> }
>
> if (sp->unsync_children)
> - kvm_make_request(KVM_REQ_TLB_FLUSH_CURRENT, vcpu);
> + kvm_make_request(KVM_REQ_MMU_SYNC, vcpu);
>
> __clear_sp_write_flooding_count(sp);
>
> --
> 2.19.1.6.gb485710b
>
next prev parent reply other threads:[~2020-08-28 1:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 10:18 [PATCH] kvm x86/mmu: use KVM_REQ_MMU_SYNC to sync when needed Lai Jiangshan
2020-08-28 1:47 ` Lai Jiangshan [this message]
2020-08-28 1:49 ` Lai Jiangshan
2020-08-31 13:09 ` Vitaly Kuznetsov
2020-09-01 1:29 ` Lai Jiangshan
2020-09-01 8:10 ` Vitaly Kuznetsov
2020-09-02 13:54 ` [PATCH V2] " Lai Jiangshan
2020-09-02 14:12 ` Vitaly Kuznetsov
2020-09-03 1:22 ` Sean Christopherson
2020-09-03 16:23 ` [PATCH V3] " Lai Jiangshan
2020-09-10 10:21 ` Lai Jiangshan
2020-09-11 17:16 ` [PATCH V2] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJhGHyDuS27+uPbqvc3Bn4aY_ncUAQo4AA_tRDZXQms-Y=r6LQ@mail.gmail.com' \
--to=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).