From: Xie He <xie.he.0141@gmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux X25 <linux-x25@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Martin Schiller <ms@dev.tdt.de>, Krzysztof Halasa <khc@pm.waw.pl>
Subject: Re: [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames
Date: Mon, 15 Feb 2021 09:23:32 -0800 [thread overview]
Message-ID: <CAJht_EOQBDdwa0keS9XTKZgXE44_b5cHJt=fFaKy-wFDpe6iaw@mail.gmail.com> (raw)
In-Reply-To: <YCo96zjXHyvKpbUM@unreal>
On Mon, Feb 15, 2021 at 1:25 AM Leon Romanovsky <leon@kernel.org> wrote:
>
> > + /* When transmitting data:
> > + * first we'll remove a pseudo header of 1 byte,
> > + * then the LAPB module will prepend an LAPB header of at most 3 bytes.
> > + */
> > + dev->needed_headroom = 3 - 1;
>
> 3 - 1 = 2
>
> Thanks
Actually this is intentional. It makes the numbers more meaningful.
The compiler should automatically generate the "2" so there would be
no runtime penalty.
next prev parent reply other threads:[~2021-02-15 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 7:27 [PATCH net-next RFC v3] net: hdlc_x25: Queue outgoing LAPB frames Xie He
2021-02-15 9:24 ` Leon Romanovsky
2021-02-15 17:23 ` Xie He [this message]
2021-02-15 18:54 ` Leon Romanovsky
2021-02-15 19:08 ` Xie He
2021-02-16 6:03 ` Leon Romanovsky
2021-02-16 7:30 ` Xie He
2021-02-16 7:39 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJht_EOQBDdwa0keS9XTKZgXE44_b5cHJt=fFaKy-wFDpe6iaw@mail.gmail.com' \
--to=xie.he.0141@gmail.com \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).