From: Xie He <xie.he.0141@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] drivers/net/wan/x25_asy: Remove an unused flag "SLF_OUTWAIT"
Date: Fri, 11 Sep 2020 16:49:45 -0700 [thread overview]
Message-ID: <CAJht_EPZdsgO9SEtgxRMTcGj5z0xJVp-LOTiU0wH41rLLfG+EA@mail.gmail.com> (raw)
In-Reply-To: <20200911.144436.1790085156026689841.davem@davemloft.net>
On Fri, Sep 11, 2020 at 2:44 PM David Miller <davem@davemloft.net> wrote:
>
> From: Xie He <xie.he.0141@gmail.com>
> Date: Thu, 10 Sep 2020 23:35:03 -0700
>
> > The "SLF_OUTWAIT" flag defined in x25_asy.h is not actually used.
> > It is only cleared at one place in x25_asy.c but is never read or set.
> > So we can remove it.
> >
> > Signed-off-by: Xie He <xie.he.0141@gmail.com>
>
> Applied, it looks like this code wss based upon the slip.c code.
Oh! You are right! I can finally understand now why there are so many
things named "sl" in this file.
prev parent reply other threads:[~2020-09-11 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 6:35 [PATCH net-next] drivers/net/wan/x25_asy: Remove an unused flag "SLF_OUTWAIT" Xie He
2020-09-11 21:44 ` David Miller
2020-09-11 23:49 ` Xie He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJht_EPZdsgO9SEtgxRMTcGj5z0xJVp-LOTiU0wH41rLLfG+EA@mail.gmail.com \
--to=xie.he.0141@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).