From: Xie He <xie.he.0141@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Martin Schiller <ms@dev.tdt.de>
Subject: Re: [PATCH net] drivers/net/wan/x25_asy: Keep the ldisc running even when netif is down
Date: Mon, 28 Sep 2020 17:36:13 -0700 [thread overview]
Message-ID: <CAJht_EPs03cTh=6PQWasZknRXOzysW-X+dC+RPMu02RsC417LA@mail.gmail.com> (raw)
In-Reply-To: <20200928.155852.490566722532403628.davem@davemloft.net>
On Mon, Sep 28, 2020 at 3:58 PM David Miller <davem@davemloft.net> wrote:
>
> It could also go back down and also back up again after you do this
> test. Maybe even 10 or 100 times over.
>
> You can't just leave things so incredibly racy like this, please apply
> proper synchronization between netdev state changes and this TTY code.
>
> Thank you.
OK! Thanks!
I'll try to ensure proper locking for the netif_running checks and re-submit.
prev parent reply other threads:[~2020-09-29 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 20:56 [PATCH net] drivers/net/wan/x25_asy: Keep the ldisc running even when netif is down Xie He
2020-09-28 22:58 ` David Miller
2020-09-29 0:36 ` Xie He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJht_EPs03cTh=6PQWasZknRXOzysW-X+dC+RPMu02RsC417LA@mail.gmail.com' \
--to=xie.he.0141@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).