From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH] arm64: dts: allwinner: h6: fix cooling-cell property
Date: Thu, 23 Apr 2020 09:48:07 +0200 [thread overview]
Message-ID: <CAJiuCccZ6OJXYBZiCnO4VmOQ2WB0CwOsVe6oaU-t5_iiovLzWw@mail.gmail.com> (raw)
In-Reply-To: <20200420143016.16835-1-peron.clem@gmail.com>
Hi Maxime,
On Mon, 20 Apr 2020 at 16:30, Clément Péron <peron.clem@gmail.com> wrote:
>
> We define cooling-cells property for CPUs only for board including
> the sun50i-h6-cpu-opp.dtsi. As not all boards have the CPU OPP
> dtsi file included this create a warning because the cooling-maps
> is defined but not the cooling-cells property in CPU nodes.
This fix some warnings introduced by the H6 DVFS serie that I sent last week...
The cooling-cells has been introduced in
7e4bbf3fe67c ("arm64: dts: allwinner: h6: Add CPU Operating
Performance Points table")
instead of
5fc0928782e9 ("arm64: dts: allwinner: h6: Add thermal trip points/cooling map")
Do you plan to squash it? If yes do you want me to sent two patches
separately (it will be a bit easier to squash them)?
Regards,
Clement
>
> Move the cooling-cells to the sun50i-h6.dtsi instead of the
> sun50i-h6-cpu-opp.dtsi
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi | 4 ----
> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++++
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
> index 9ebd97b04b1a..dcb789519797 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-cpu-opp.dtsi
> @@ -102,20 +102,16 @@
>
> &cpu0 {
> operating-points-v2 = <&cpu_opp_table>;
> - #cooling-cells = <2>;
> };
>
> &cpu1 {
> operating-points-v2 = <&cpu_opp_table>;
> - #cooling-cells = <2>;
> };
>
> &cpu2 {
> operating-points-v2 = <&cpu_opp_table>;
> - #cooling-cells = <2>;
> };
>
> &cpu3 {
> operating-points-v2 = <&cpu_opp_table>;
> - #cooling-cells = <2>;
> };
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> index 83e32f9c4977..2e31632c6ca8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> @@ -27,6 +27,7 @@
> enable-method = "psci";
> clocks = <&ccu CLK_CPUX>;
> clock-latency-ns = <244144>; /* 8 32k periods */
> + #cooling-cells = <2>;
> };
>
> cpu1: cpu@1 {
> @@ -36,6 +37,7 @@
> enable-method = "psci";
> clocks = <&ccu CLK_CPUX>;
> clock-latency-ns = <244144>; /* 8 32k periods */
> + #cooling-cells = <2>;
> };
>
> cpu2: cpu@2 {
> @@ -45,6 +47,7 @@
> enable-method = "psci";
> clocks = <&ccu CLK_CPUX>;
> clock-latency-ns = <244144>; /* 8 32k periods */
> + #cooling-cells = <2>;
> };
>
> cpu3: cpu@3 {
> @@ -54,6 +57,7 @@
> enable-method = "psci";
> clocks = <&ccu CLK_CPUX>;
> clock-latency-ns = <244144>; /* 8 32k periods */
> + #cooling-cells = <2>;
> };
> };
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-04-23 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 14:30 [PATCH] arm64: dts: allwinner: h6: fix cooling-cell property Clément Péron
2020-04-23 7:48 ` Clément Péron [this message]
2020-04-23 9:44 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJiuCccZ6OJXYBZiCnO4VmOQ2WB0CwOsVe6oaU-t5_iiovLzWw@mail.gmail.com \
--to=peron.clem@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).