linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6
@ 2018-11-05 13:58 Clément Péron
  2018-11-16  2:59 ` Shawn Guo
  0 siblings, 1 reply; 6+ messages in thread
From: Clément Péron @ 2018-11-05 13:58 UTC (permalink / raw)
  To: NXP Linux Team
  Cc: Vladimir Zapolskiy, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Rob Herring, devicetree,
	linux-kernel, linux-arm-kernel, Colin Didier,
	Clément Péron

From: Colin Didier <colin.didier@devialet.com>

The MX6 Audmux differs from MX51.

This patch adds the audmux for i.MX6 family.

Signed-off-by: Colin Didier <colin.didier@devialet.com>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/dt-bindings/sound/fsl-imx-audmux.h b/include/dt-bindings/sound/fsl-imx-audmux.h
index 15f138bebe16..a1d0741d9ed1 100644
--- a/include/dt-bindings/sound/fsl-imx-audmux.h
+++ b/include/dt-bindings/sound/fsl-imx-audmux.h
@@ -25,6 +25,14 @@
 #define MX51_AUDMUX_PORT6		5
 #define MX51_AUDMUX_PORT7		6
 
+#define MX6_AUDMUX_PORT1_SSI1		0
+#define MX6_AUDMUX_PORT2_SSI2		1
+#define MX6_AUDMUX_PORT3		2
+#define MX6_AUDMUX_PORT4		3
+#define MX6_AUDMUX_PORT5		4
+#define MX6_AUDMUX_PORT6		5
+#define MX6_AUDMUX_PORT7_SSI3		6
+
 /*
  * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
  * can be sourced from Rx/Tx.
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6
  2018-11-05 13:58 [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6 Clément Péron
@ 2018-11-16  2:59 ` Shawn Guo
  2018-11-16 10:25   ` Clément Péron
  0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2018-11-16  2:59 UTC (permalink / raw)
  To: Clément Péron
  Cc: NXP Linux Team, Vladimir Zapolskiy, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Rob Herring, devicetree,
	linux-kernel, linux-arm-kernel, Colin Didier

On Mon, Nov 05, 2018 at 02:58:02PM +0100, Clément Péron wrote:
> From: Colin Didier <colin.didier@devialet.com>
> 
> The MX6 Audmux differs from MX51.
> 
> This patch adds the audmux for i.MX6 family.
> 
> Signed-off-by: Colin Didier <colin.didier@devialet.com>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

I think you should send it to ASoC maintainer and list for applying.

Shawn

> ---
>  include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/dt-bindings/sound/fsl-imx-audmux.h b/include/dt-bindings/sound/fsl-imx-audmux.h
> index 15f138bebe16..a1d0741d9ed1 100644
> --- a/include/dt-bindings/sound/fsl-imx-audmux.h
> +++ b/include/dt-bindings/sound/fsl-imx-audmux.h
> @@ -25,6 +25,14 @@
>  #define MX51_AUDMUX_PORT6		5
>  #define MX51_AUDMUX_PORT7		6
>  
> +#define MX6_AUDMUX_PORT1_SSI1		0
> +#define MX6_AUDMUX_PORT2_SSI2		1
> +#define MX6_AUDMUX_PORT3		2
> +#define MX6_AUDMUX_PORT4		3
> +#define MX6_AUDMUX_PORT5		4
> +#define MX6_AUDMUX_PORT6		5
> +#define MX6_AUDMUX_PORT7_SSI3		6
> +
>  /*
>   * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
>   * can be sourced from Rx/Tx.
> -- 
> 2.19.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6
  2018-11-16  2:59 ` Shawn Guo
@ 2018-11-16 10:25   ` Clément Péron
  2018-11-16 14:45     ` Shawn Guo
  0 siblings, 1 reply; 6+ messages in thread
From: Clément Péron @ 2018-11-16 10:25 UTC (permalink / raw)
  To: Shawn Guo
  Cc: NXP Linux Team, Vladimir Zapolskiy, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Rob Herring, devicetree,
	linux-kernel, linux-arm-kernel, Colin Didier

Hi Shawn,

On Fri, 16 Nov 2018 at 03:59, Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Mon, Nov 05, 2018 at 02:58:02PM +0100, Clément Péron wrote:
> > From: Colin Didier <colin.didier@devialet.com>
> >
> > The MX6 Audmux differs from MX51.
> >
> > This patch adds the audmux for i.MX6 family.
> >
> > Signed-off-by: Colin Didier <colin.didier@devialet.com>
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
>
> I think you should send it to ASoC maintainer and list for applying.

It's still quite new for me to submit patch, but if this patch should
be sent to ASoC maintainer maybe there is a line missing in the
MAINTAINERS file no ?

SOUND
M:      Jaroslav Kysela <perex@perex.cz>
M:      Takashi Iwai <tiwai@suse.com>
L:      alsa-devel@alsa-project.org (moderated for non-subscribers)
W:      http://www.alsa-project.org/
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
T:      git git://git.alsa-project.org/alsa-kernel.git
Q:      http://patchwork.kernel.org/project/alsa-devel/list/
S:      Maintained
F:      Documentation/sound/
+ F:      include/dt-bindings/sound/
F:      include/sound/
F:      include/uapi/sound/
F:      sound/

Regards,
Clement

>
> Shawn
>
> > ---
> >  include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/include/dt-bindings/sound/fsl-imx-audmux.h b/include/dt-bindings/sound/fsl-imx-audmux.h
> > index 15f138bebe16..a1d0741d9ed1 100644
> > --- a/include/dt-bindings/sound/fsl-imx-audmux.h
> > +++ b/include/dt-bindings/sound/fsl-imx-audmux.h
> > @@ -25,6 +25,14 @@
> >  #define MX51_AUDMUX_PORT6            5
> >  #define MX51_AUDMUX_PORT7            6
> >
> > +#define MX6_AUDMUX_PORT1_SSI1                0
> > +#define MX6_AUDMUX_PORT2_SSI2                1
> > +#define MX6_AUDMUX_PORT3             2
> > +#define MX6_AUDMUX_PORT4             3
> > +#define MX6_AUDMUX_PORT5             4
> > +#define MX6_AUDMUX_PORT6             5
> > +#define MX6_AUDMUX_PORT7_SSI3                6
> > +
> >  /*
> >   * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
> >   * can be sourced from Rx/Tx.
> > --
> > 2.19.1
> >

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6
  2018-11-16 10:25   ` Clément Péron
@ 2018-11-16 14:45     ` Shawn Guo
  2018-11-17  3:09       ` Mark Brown
  0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2018-11-16 14:45 UTC (permalink / raw)
  To: Clément Péron, Mark Brown
  Cc: NXP Linux Team, Vladimir Zapolskiy, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Rob Herring, devicetree,
	linux-kernel, linux-arm-kernel, Colin Didier

On Fri, Nov 16, 2018 at 11:25:07AM +0100, Clément Péron wrote:
> Hi Shawn,
> 
> On Fri, 16 Nov 2018 at 03:59, Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Mon, Nov 05, 2018 at 02:58:02PM +0100, Clément Péron wrote:
> > > From: Colin Didier <colin.didier@devialet.com>
> > >
> > > The MX6 Audmux differs from MX51.
> > >
> > > This patch adds the audmux for i.MX6 family.
> > >
> > > Signed-off-by: Colin Didier <colin.didier@devialet.com>
> > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> >
> > I think you should send it to ASoC maintainer and list for applying.
> 
> It's still quite new for me to submit patch, but if this patch should
> be sent to ASoC maintainer maybe there is a line missing in the
> MAINTAINERS file no ?

@Mark, comment?

Shawn

> 
> SOUND
> M:      Jaroslav Kysela <perex@perex.cz>
> M:      Takashi Iwai <tiwai@suse.com>
> L:      alsa-devel@alsa-project.org (moderated for non-subscribers)
> W:      http://www.alsa-project.org/
> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
> T:      git git://git.alsa-project.org/alsa-kernel.git
> Q:      http://patchwork.kernel.org/project/alsa-devel/list/
> S:      Maintained
> F:      Documentation/sound/
> + F:      include/dt-bindings/sound/
> F:      include/sound/
> F:      include/uapi/sound/
> F:      sound/
> 
> Regards,
> Clement
> 
> >
> > Shawn
> >
> > > ---
> > >  include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > >
> > > diff --git a/include/dt-bindings/sound/fsl-imx-audmux.h b/include/dt-bindings/sound/fsl-imx-audmux.h
> > > index 15f138bebe16..a1d0741d9ed1 100644
> > > --- a/include/dt-bindings/sound/fsl-imx-audmux.h
> > > +++ b/include/dt-bindings/sound/fsl-imx-audmux.h
> > > @@ -25,6 +25,14 @@
> > >  #define MX51_AUDMUX_PORT6            5
> > >  #define MX51_AUDMUX_PORT7            6
> > >
> > > +#define MX6_AUDMUX_PORT1_SSI1                0
> > > +#define MX6_AUDMUX_PORT2_SSI2                1
> > > +#define MX6_AUDMUX_PORT3             2
> > > +#define MX6_AUDMUX_PORT4             3
> > > +#define MX6_AUDMUX_PORT5             4
> > > +#define MX6_AUDMUX_PORT6             5
> > > +#define MX6_AUDMUX_PORT7_SSI3                6
> > > +
> > >  /*
> > >   * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
> > >   * can be sourced from Rx/Tx.
> > > --
> > > 2.19.1
> > >

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6
  2018-11-16 14:45     ` Shawn Guo
@ 2018-11-17  3:09       ` Mark Brown
  2018-11-17 12:15         ` Clément Péron
  0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2018-11-17  3:09 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Clément Péron, NXP Linux Team, Vladimir Zapolskiy,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	Rob Herring, devicetree, linux-kernel, linux-arm-kernel,
	Colin Didier

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

On Fri, Nov 16, 2018 at 10:45:22PM +0800, Shawn Guo wrote:
> On Fri, Nov 16, 2018 at 11:25:07AM +0100, Clément Péron wrote:

> > It's still quite new for me to submit patch, but if this patch should
> > be sent to ASoC maintainer maybe there is a line missing in the
> > MAINTAINERS file no ?

> @Mark, comment?

Adding a file pattern for this seems sensible, yes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6
  2018-11-17  3:09       ` Mark Brown
@ 2018-11-17 12:15         ` Clément Péron
  0 siblings, 0 replies; 6+ messages in thread
From: Clément Péron @ 2018-11-17 12:15 UTC (permalink / raw)
  To: Mark Brown
  Cc: Shawn Guo, NXP Linux Team, Vladimir Zapolskiy, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, Rob Herring, devicetree,
	linux-kernel, linux-arm-kernel, Colin Didier

Hi Mark,

On Sat, 17 Nov 2018 at 04:09, Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Nov 16, 2018 at 10:45:22PM +0800, Shawn Guo wrote:
> > On Fri, Nov 16, 2018 at 11:25:07AM +0100, Clément Péron wrote:
>
> > > It's still quite new for me to submit patch, but if this patch should
> > > be sent to ASoC maintainer maybe there is a line missing in the
> > > MAINTAINERS file no ?
>
> > @Mark, comment?
>
> Adding a file pattern for this seems sensible, yes.
OK,

I will send a v2 for the IMX6 Audmux bindings with ASoC List and Maintainers.

Thanks,
Clement

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-11-17 12:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05 13:58 [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6 Clément Péron
2018-11-16  2:59 ` Shawn Guo
2018-11-16 10:25   ` Clément Péron
2018-11-16 14:45     ` Shawn Guo
2018-11-17  3:09       ` Mark Brown
2018-11-17 12:15         ` Clément Péron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).