linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Clément Péron" <peron.clem@gmail.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Maxime Ripard <maxime@cerno.tech>,
	Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] Re: [PATCH 0/7] Pine64 PineCube support
Date: Sat, 3 Oct 2020 15:37:34 +0200	[thread overview]
Message-ID: <CAJiuCcfB_cgP0YwWOeCtpbq+=SZi+12=BjaEe4ZSz2p8dHQZtg@mail.gmail.com> (raw)
In-Reply-To: <0BAFC9B7-DC42-469A-9C90-E25779678C07@aosc.io>

Hi Icenowy,

On Sat, 3 Oct 2020 at 12:39, Icenowy Zheng <icenowy@aosc.io> wrote:
>
>
>
> 于 2020年10月3日 GMT+08:00 下午6:28:03, "Clément Péron" <peron.clem@gmail.com> 写到:
> >Hi,
> >
> >I was running dtbs_check and found this series introduced new warnings.
> >
> >  DTC     arch/arm/boot/dts/sun8i-s3-pinecube.dtb
> >  DTC     arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml
> >  CHECK   arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible: ['allwinner,sun8i-v3s-system-control',
> >'allwinner,sun8i-h3-system-control'] is not valid under any of the
> >given schemas (Possible causes of the failure):
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible: Additional items are not allowed
> >('allwinner,sun8i-h3-system-control' was unexpected)
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun4i-a10-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun5i-a13-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun7i-a20-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun8i-a23-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun8i-h3-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun8i-r40-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun50i-a64-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun50i-h5-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,sun50i-h6-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:0: 'allwinner,suniv-f1c100s-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:1: 'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:1: 'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:1: 'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: system-control@1c00000:
> >compatible:1: 'allwinner,sun4i-a10-system-control' was expected
> >
> >From schema:
> >/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> >/arch/arm/boot/dts/sun8i-s3-pinecube.dt.yaml: camera@1cb4000: port:
> >'#address-cells', '#size-cells' do not match any of the regexes:
> >'pinctrl-[0-9]+'
> >From schema:
> >/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
>
> Is this broken schema?

I think the #address-cells', '#size-cells' are not required here.
I had a quick look at other csi and nobody seems to specify this.

Just FYI This is what I did.
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master
ARCH=arm make sunxi_defconfig
ARCH=arm make -j8 dtbs_check

Regards,
Clement

> >
> >And also some other boards
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:
> >['allwinner,sun8i-v3s-system-control',
> >'allwinner,sun8i-h3-system-control'] is not valid under any of the
> >given schemas (Possible causes of the failure):
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible: Additional items are not allowed
> >('allwinner,sun8i-h3-system-control' was unexpected)
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun5i-a13-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun7i-a20-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-a23-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-h3-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-r40-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h5-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h6-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,suniv-f1c100s-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-s3-lichee-zero-plus.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >
> >From schema:
> >/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:
> >['allwinner,sun8i-v3s-system-control',
> >'allwinner,sun8i-h3-system-control'] is not valid under any of the
> >given schemas (Possible causes of the failure):
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible: Additional items are not allowed
> >('allwinner,sun8i-h3-system-control' was unexpected)
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun5i-a13-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun7i-a20-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-a23-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-h3-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-r40-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h5-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h6-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,suniv-f1c100s-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >
> >From schema:
> >/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:
> >['allwinner,sun8i-v3s-system-control',
> >'allwinner,sun8i-h3-system-control'] is not valid under any of the
> >given schemas (Possible causes of the failure):
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible: Additional items are not allowed
> >('allwinner,sun8i-h3-system-control' was unexpected)
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun5i-a13-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun7i-a20-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-a23-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-h3-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun8i-r40-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-sram-controller' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h5-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,sun50i-h6-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:0:
> >'allwinner,suniv-f1c100s-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun50i-a64-system-control' was expected
> >/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dt.yaml:
> >system-control@1c00000: compatible:1:
> >'allwinner,sun4i-a10-system-control' was expected
> >
> >Regards,
> >Clement
> >
> >On Fri, 25 Sep 2020 at 17:12, Maxime Ripard <maxime@cerno.tech> wrote:
> >>
> >> Hi,
> >>
> >> On Wed, Sep 23, 2020 at 08:57:02AM +0800, Icenowy Zheng wrote:
> >> > Pine64 PineCube is an IP camera based on Allwinner S3 chip.
> >> >
> >> > This patchset tries to add support for it.
> >> >
> >> > In order to make sure the system do not hang when camera is brought
> >up,
> >> > a fix to AXP209 driver is needed (sent individually), otherwise the
> >> > system will hang because it changes the voltage of LDO2 when LDO4
> >> > tweaking.
> >>
> >> Queued all the patches for 5.11
> >>
> >> > Icenowy Zheng (7):
> >> >   ARM: dts: sun8i: V3/V3s/S3/S3L: add Ethernet support
> >> >   ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for UART2 RX/TX
> >> >   ARM: dts: sun8i: V3/V3s/S3/S3L: add CSI1 device node
> >> >   ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for 8-bit parallel
> >CSI
> >> >   ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for I2C1 at PE bank
> >> >   dt-bindings: arm: sunxi: add Pine64 PineCube binding
> >> >   ARM: dts: sun8i: s3l: add support for Pine64 PineCube IP camera
> >>
> >> However, I guess for the next patches to the v3s DTSI we should just
> >> have a simpler prefix (like v3), it's really taking a lot of
> >characters
> >> here :)
> >>
> >> Maxime
> >>
> >> --
> >> You received this message because you are subscribed to the Google
> >Groups "linux-sunxi" group.
> >> To unsubscribe from this group and stop receiving emails from it,
> >send an email to linux-sunxi+unsubscribe@googlegroups.com.
> >> To view this discussion on the web, visit
> >https://groups.google.com/d/msgid/linux-sunxi/20200925151241.kfmytlff4grswtzh%40gilmour.lan.

      reply	other threads:[~2020-10-03 13:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  0:57 [PATCH 0/7] Pine64 PineCube support Icenowy Zheng
2020-09-23  0:57 ` [PATCH 1/7] ARM: dts: sun8i: V3/V3s/S3/S3L: add Ethernet support Icenowy Zheng
2020-09-23  0:58 ` [PATCH 2/7] ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for UART2 RX/TX Icenowy Zheng
2020-09-23  0:58   ` [PATCH 3/7] ARM: dts: sun8i: V3/V3s/S3/S3L: add CSI1 device node Icenowy Zheng
2020-09-23  1:00 ` [PATCH 4/7] ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for 8-bit parallel CSI Icenowy Zheng
2020-09-23  1:00   ` [PATCH 5/7] ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for I2C1 at PE bank Icenowy Zheng
2020-09-23  1:01 ` [PATCH 4/7] ARM: dts: sun8i: V3/V3s/S3/S3L: add pinctrl for 8-bit parallel CSI Icenowy Zheng
2020-09-23  1:02 ` [PATCH 6/7] dt-bindings: arm: sunxi: add Pine64 PineCube binding Icenowy Zheng
2020-09-23  1:02   ` [PATCH 7/7] ARM: dts: sun8i: s3l: add support for Pine64 PineCube IP camera Icenowy Zheng
2020-09-25 15:12 ` [PATCH 0/7] Pine64 PineCube support Maxime Ripard
2020-10-03 10:28   ` [linux-sunxi] " Clément Péron
2020-10-03 10:31     ` Clément Péron
2020-10-03 10:39     ` Icenowy Zheng
2020-10-03 13:37       ` Clément Péron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJiuCcfB_cgP0YwWOeCtpbq+=SZi+12=BjaEe4ZSz2p8dHQZtg@mail.gmail.com' \
    --to=peron.clem@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).