From: "Clément Péron" <firstname.lastname@example.org> To: email@example.com Cc: Dinh Nguyen <firstname.lastname@example.org>, Florian Fainelli <email@example.com>, Russell King <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH] ARM: debug: enable UART1 for socfpga Cyclone5 Date: Wed, 24 Oct 2018 16:11:59 +0200 [thread overview] Message-ID: <CAJiuCcfZ7+gaxA5iGhS48eODPsTaZc5-Bd2zXqaAgtNd0fwSKg@mail.gmail.com> (raw) In-Reply-To: <email@example.com> Hi, On Wed, 24 Oct 2018 at 08:51, Uwe Kleine-König <firstname.lastname@example.org> wrote: > > On Tue, Oct 23, 2018 at 03:35:31PM -0500, Dinh Nguyen wrote: > > > > > > On 10/23/2018 09:44 AM, Clément Péron wrote: > > > HI Dinh, > > > > > > On Tue, 23 Oct 2018 at 16:04, Dinh Nguyen <email@example.com> wrote: > > >> > > >> Hi Clément, > > >> > > >> On 10/09/2018 06:28 AM, Clément Péron wrote: > > >>> Cyclone5 and Arria10 doesn't have the same memory map for UART1. > > >>> > > >>> Split the SOCFPGA_UART1 into 2 options to allow debugging on UART1 for Cylone5. > > >>> > > >> > > >> I'm not sure the need for this patch. Are there any cyclone5 based > > >> boards that has UART1 as the debug uart? I see that all of them are > > >> using UART0. > > > > > > There is no upstream device with this UART used. But the board I have > > > use it, and there is no limitation to not have it available upstream > > > no ? > > > > > > > I see. Then I don't think the patch is applicable because none of the > > upstream devices need it. Now, if you were to upstream your board that > > uses UART1, then there will be a case for this patch. Do you agree? I don't think my board is upstreamable it's not a devkit and not really interesting for the community. It's really a trivial patch and it will avoid wasting time to another owner of CycloneV board who would like to have debug on UART1 Thanks Clement > > I'd not say having to upstream the board is a sensible precondition for > such a patch. One of the arguments for moving ARM to dt was that this > allows to separate the machine specifics from the code. So I'd say if > Clément has a need, this is a good enough reason to take this patch. > > Just my 0.02 €, > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-10-24 14:12 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-09 11:28 Clément Péron 2018-10-23 14:04 ` Dinh Nguyen 2018-10-23 14:44 ` Clément Péron 2018-10-23 20:35 ` Dinh Nguyen 2018-10-24 6:51 ` Uwe Kleine-König 2018-10-24 14:11 ` Clément Péron [this message] 2018-10-25 14:57 ` Dinh Nguyen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJiuCcfZ7+gaxA5iGhS48eODPsTaZc5-Bd2zXqaAgtNd0fwSKg@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] ARM: debug: enable UART1 for socfpga Cyclone5' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).