From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1544C54F70 for ; Sun, 19 Apr 2020 18:23:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1498214AF for ; Sun, 19 Apr 2020 18:23:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Afs/bhME" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbgDSSXB (ORCPT ); Sun, 19 Apr 2020 14:23:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725969AbgDSSXB (ORCPT ); Sun, 19 Apr 2020 14:23:01 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF504C061A0F for ; Sun, 19 Apr 2020 11:23:00 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id f59so2352376uaf.9 for ; Sun, 19 Apr 2020 11:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc :content-transfer-encoding; bh=OkSXlLd1OI6YTd2bVj1Y/vakCv0k00Q6ubPQGf9tb58=; b=Afs/bhMEDq2p1dCZuoTJywON2+IgPM8lLUhQ9O0GtNPjL0aIWgaI5nzl7Ukcrlbwrt F0uRHV3C8VvOViv3vFJV/yd9EuepaKKEA+Nl4fPLLJxobSZFPSjvWg5uceQDZlus1/dV KxQi8p7LBLMA4exdiEosaT1uuuPCwnJ7gB0bIsARwJDFptIPXTPEyLoUCHW21hja2pA/ lz7o/HRAQRJtMH1QW9ZYe/UJkC0uYonnOL/rrDqHSHphKHp5k4DuaztWRJ465OiLtrhB LIvJYJXB4Clbe/dIg9Lh+Lsc8EwEHo09YRpuG+j3Lw+duGVleSvE3sPS9pJe+sqamBM6 qlDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc:content-transfer-encoding; bh=OkSXlLd1OI6YTd2bVj1Y/vakCv0k00Q6ubPQGf9tb58=; b=EV+35QNUFJUtA+HcADJa2bJrfjJOp6Ha1wttmJbvAgD3d1NNLxyuU6AbhSBlz4IvWD YdxfMz1YnhJ6clxu+XQHmWvLjhFDUZF9Qhfn6Vxw0Sdg0UnetzOop/LuhQ2KE3PaGvW1 H6qvZKgnyOSMNXvwXr5cgh1CQH9iuk8YXwqs7SINHYJNQ8mUhBzZwpfKaz8Qm2zORgUs G22SoASwb1nB7KRdNoG3i60eSDX7+WAVsJeNyi06jtNa8CMWdfBT7taN81hv+avWGGBt 48jeubJewQG40l9ruRgpf7hW45GVi1sBz3CbMLzmJplmAj8HMkZhXFezb+IGD3VvM/Q7 WaLA== X-Gm-Message-State: AGi0PuZRyFnpgF1L11CGnGAONptOPJbW2OWi6XJbkgXvfECVc7igYJIr KWuOR/fHuPB/6lBlGjn++oMt3W3YqsmzB/Ba3jY= X-Received: by 2002:ab0:375a:: with SMTP id i26mt6009964uat.120.1587320579776; Sun, 19 Apr 2020 11:22:59 -0700 (PDT) MIME-Version: 1.0 References: <20200419041651.GD166864@dtor-ws> <20200419074624.9955-1-priv.luk@gmail.com> <20200419180136.GK166864@dtor-ws> In-Reply-To: From: LuK1337 Date: Sun, 19 Apr 2020 20:22:48 +0200 Message-ID: Subject: Re: [PATCH] Input: xpad - Update xboxone fw2015 init packet Cc: LuK1337 , Dmitry Torokhov , Allison Randal , Greg Kroah-Hartman , Thomas Gleixner , Richard Fontana , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I had this issue with official Microsoft Xbox One S Controler (model: 1708)= ; It might also be firmware version related as I recently updated my firmware to the latest one but I'm not sure about that. (also sorry for duplicate msgs that you might have received from me; I'm new to lkml) On Sun, Apr 19, 2020 at 8:14 PM LuK1337 wrote: > > I had this issue with official Microsoft Xbox One S Controler (model: 170= 8); > It might also be firmware version related as I recently updated my firmwa= re > to the latest one but I'm not sure about that. > > On Sun, Apr 19, 2020 at 8:01 PM Dmitry Torokhov wrote: >> >> On Sun, Apr 19, 2020 at 09:46:23AM +0200, LuK1337 wrote: >> > From: =C5=81ukasz Patron >> > >> > Appending { 0x05, 0x20, 0x02, 0x0f, 0x06 } to >> > xboxone_fw2015_init fixes an issue where the >> > controller is somewhat stuck in bluetooth >> > mode until you plug it into Windows PC. >> > >> > Signed-off-by: =C5=81ukasz Patron >> >> Thank you =C5=81ukasz. Could you please tell me what device(s) have you >> observed the issue with? I am a bit worried if this may interfere with >> other devices that currently work fine with the driver. Cameron, Mark, >> do you have any concerns here? >> >> > --- >> > drivers/input/joystick/xpad.c | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xp= ad.c >> > index 6b40a1c68f9f..894fa81f717a 100644 >> > --- a/drivers/input/joystick/xpad.c >> > +++ b/drivers/input/joystick/xpad.c >> > @@ -455,7 +455,8 @@ struct xboxone_init_packet { >> > * or later firmware installed (or present from the factory). >> > */ >> > static const u8 xboxone_fw2015_init[] =3D { >> > - 0x05, 0x20, 0x00, 0x01, 0x00 >> > + 0x05, 0x20, 0x00, 0x01, 0x00, >> > + 0x05, 0x20, 0x02, 0x0f, 0x06 >> > }; >> > >> > /* >> > -- >> > 2.26.0 >> > >> >> Thanks. >> >> -- >> Dmitry