From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 664B3C43334 for ; Tue, 7 Jun 2022 13:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244547AbiFGNSL (ORCPT ); Tue, 7 Jun 2022 09:18:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232262AbiFGNSI (ORCPT ); Tue, 7 Jun 2022 09:18:08 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7A1967D11; Tue, 7 Jun 2022 06:18:07 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id bo5so15526396pfb.4; Tue, 07 Jun 2022 06:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pEUfspnU4Q0xYV8O4jrnwA8T8Qz0Rm4rMMQGRXaaEVY=; b=lZ90L9piIk3lL/kkGtkHRka/aIQiV2WjQgZJHkux3fy1fqyTPqrZ4ya4GPOia6M9z6 dMcXDe/6Pca1qk+DEQcz/8pQ3WyR4u6TnG6z4TepPMUJ1rkI7ew76oDJfyFARH+dihNq BTjuvKyQUlNcISuqED/RrfAaneg3nWNquhN+EBPiXaEmjpCQB55HkCSRR0/yjKc/kd6N on9WB+TPN048+MrhPICItQ2fn1fV+DeDGItoDzdEcTAaVrccp5c40svm+VlESHN3fd15 /RkQKpe9aQsavoJF/ZIJTUq04di35Grr8/BPDNxktfbGOdUK4YqKeMc4Ts0ZeuDuoYCe HoGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pEUfspnU4Q0xYV8O4jrnwA8T8Qz0Rm4rMMQGRXaaEVY=; b=XmG+H3CxsZN449+3LuuAreSZSztli6PqFeYBreNqKCzVWXRscXL/jGrGizY/WT+i+X q62vtXV3YC1gfybUbNTD5t6f5nRwuP++XrO3DBILCJVlI9GUdECVfEI0yQ5+FX9kE1XY 04GbwB4XWkmhdolTQrguhKX6Gkov6UGeSVWiycV36Pw+nE0MMhKuDo4X5rbXF9ZzirB+ UhC1RUoi22pAO/w3egJIM7Yg899dfV2QqhNjp6+tNJqWXuz53cHOHxDPbeDvT1udnjHl aMnZQYtj05T13gBoeJWwi105ArWgirY+cfzoeMkOpspBwy3m4rOFFpbjDFwiJlg5mCYQ mPkg== X-Gm-Message-State: AOAM5302jSHRAlejDM5orlLQ59m1khg81hnG5w7cn67ZIgLBT2EL6TAp KRbUbYLXCwvjXZUuzwUITsnn6fjiX8lHToWga60= X-Google-Smtp-Source: ABdhPJycsTwXH8xUByy1rPdgeLJE1lA7z9hSbDXuUbVFW1jS3hqVpM2IbprOGUMcSUD+KSomBS2BfU+6Rrfdmlw3E2Y= X-Received: by 2002:a63:cc09:0:b0:3fb:aae7:4964 with SMTP id x9-20020a63cc09000000b003fbaae74964mr25199375pgf.118.1654607887120; Tue, 07 Jun 2022 06:18:07 -0700 (PDT) MIME-Version: 1.0 References: <20220606134553.2919693-1-alvin@pqrs.dk> <20220606134553.2919693-4-alvin@pqrs.dk> In-Reply-To: <20220606134553.2919693-4-alvin@pqrs.dk> From: Luiz Angelo Daros de Luca Date: Tue, 7 Jun 2022 10:17:56 -0300 Message-ID: Subject: Re: [PATCH net-next 3/5] net: dsa: realtek: rtl8365mb: correct the max number of ports To: =?UTF-8?Q?Alvin_=C5=A0ipraga?= Cc: Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , "open list:NETWORKING DRIVERS" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em seg., 6 de jun. de 2022 =C3=A0s 10:46, Alvin =C5=A0ipraga escreveu: > > From: Alvin =C5=A0ipraga > > The maximum number of ports is actually 11, according to two > observations: > > 1. The highest port ID used in the vendor driver is 10. Since port IDs > are indexed from 0, and since DSA follows the same numbering system, > this means up to 11 ports are to be presumed. > > 2. The registers with port mask fields always amount to a maximum port > mask of 0x7FF, corresponding to a maximum 11 ports. > /* valid for all 6-port or less variants */ It makes sense for the family. The 10-ports variants have 0-7 user ports and ext0,1,2 declared in rtl8367c driver, although no model I know does use ext2. Reviewed-by: Luiz Angelo Daros de Luca