From: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, jthumshirn@suse.de
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Brajeswar Ghosh <brajeswar.linux@gmail.com>
Subject: Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent
Date: Sat, 1 Dec 2018 18:40:02 +0530 [thread overview]
Message-ID: <CAJr6mf11gp9iV=NiFEFyo7kSZfCfMsEySdijem_PhMFEAwqucA@mail.gmail.com> (raw)
In-Reply-To: <5bf56248.1c69fb81.21a6e.5a72@mx.google.com>
On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> Replace dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Any comment on this patch?
> ---
> drivers/scsi/mvsas/mv_init.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
> index 3ac3437..495bddb 100644
> --- a/drivers/scsi/mvsas/mv_init.c
> +++ b/drivers/scsi/mvsas/mv_init.c
> @@ -253,33 +253,29 @@ static int mvs_alloc(struct mvs_info *mvi, struct Scsi_Host *shost)
> /*
> * alloc and init our DMA areas
> */
> - mvi->tx = dma_alloc_coherent(mvi->dev,
> + mvi->tx = dma_zalloc_coherent(mvi->dev,
> sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ,
> &mvi->tx_dma, GFP_KERNEL);
> if (!mvi->tx)
> goto err_out;
> - memset(mvi->tx, 0, sizeof(*mvi->tx) * MVS_CHIP_SLOT_SZ);
> - mvi->rx_fis = dma_alloc_coherent(mvi->dev, MVS_RX_FISL_SZ,
> + mvi->rx_fis = dma_zalloc_coherent(mvi->dev, MVS_RX_FISL_SZ,
> &mvi->rx_fis_dma, GFP_KERNEL);
> if (!mvi->rx_fis)
> goto err_out;
> - memset(mvi->rx_fis, 0, MVS_RX_FISL_SZ);
>
> - mvi->rx = dma_alloc_coherent(mvi->dev,
> + mvi->rx = dma_zalloc_coherent(mvi->dev,
> sizeof(*mvi->rx) * (MVS_RX_RING_SZ + 1),
> &mvi->rx_dma, GFP_KERNEL);
> if (!mvi->rx)
> goto err_out;
> - memset(mvi->rx, 0, sizeof(*mvi->rx) * (MVS_RX_RING_SZ + 1));
> mvi->rx[0] = cpu_to_le32(0xfff);
> mvi->rx_cons = 0xfff;
>
> - mvi->slot = dma_alloc_coherent(mvi->dev,
> + mvi->slot = dma_zalloc_coherent(mvi->dev,
> sizeof(*mvi->slot) * slot_nr,
> &mvi->slot_dma, GFP_KERNEL);
> if (!mvi->slot)
> goto err_out;
> - memset(mvi->slot, 0, sizeof(*mvi->slot) * slot_nr);
>
> mvi->bulk_buffer = dma_alloc_coherent(mvi->dev,
> TRASH_BUCKET_SIZE,
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-12-01 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 13:48 [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent Sabyasachi Gupta
2018-12-01 13:10 ` Sabyasachi Gupta [this message]
2018-12-19 13:19 ` Sabyasachi Gupta
2019-01-04 12:48 ` Sabyasachi Gupta
2019-01-04 13:13 ` John Garry
2019-01-04 15:11 ` Sabyasachi Gupta
2019-01-04 16:04 ` John Garry
2019-01-04 19:49 ` Souptick Joarder
2019-01-07 13:50 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJr6mf11gp9iV=NiFEFyo7kSZfCfMsEySdijem_PhMFEAwqucA@mail.gmail.com' \
--to=sabyasachi.linux@gmail.com \
--cc=brajeswar.linux@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jrdr.linux@gmail.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).