From: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
To: jthumshirn@suse.de
Cc: john.garry@huawei.com, satishkh@cisco.com, sebaddel@cisco.com,
kartilak@cisco.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com,
Souptick Joarder <jrdr.linux@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Brajeswar Ghosh <brajeswar.linux@gmail.com>
Subject: Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
Date: Tue, 13 Nov 2018 21:34:59 +0530 [thread overview]
Message-ID: <CAJr6mf1Og4uNG3gOu56EBrm+2MQGg9=SZ2mCn9hQ=+8Er-WkBw@mail.gmail.com> (raw)
In-Reply-To: <13d3418f-49d1-d683-48a6-cedbc073d86f@suse.de>
On Tue, Nov 13, 2018 at 9:23 PM Johannes Thumshirn <jthumshirn@suse.de> wrote:
>
> On 13/11/2018 16:44, John Garry wrote:
> > On 13/11/2018 15:08, Sabyasachi Gupta wrote:
> >> Replaced vmalloc + memset with vzalloc
> >>
> >> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> >> ---
> >> drivers/scsi/fnic/fnic_trace.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/scsi/fnic/fnic_trace.c
> >> b/drivers/scsi/fnic/fnic_trace.c
> >> index 8271785..129ab27 100644
> >> --- a/drivers/scsi/fnic/fnic_trace.c
> >> +++ b/drivers/scsi/fnic/fnic_trace.c
> >> @@ -468,14 +468,14 @@ int fnic_trace_buf_init(void)
> >> fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
> >> FNIC_ENTRY_SIZE_BYTES;
> >>
> >> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages *
> >> PAGE_SIZE));
> >> + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages *
> >> + PAGE_SIZE));
> >
> > If you remove the extra brackets in vzalloc() argument then you may not
> > spill onto the next line.
>
> And remove the unnecessary cast. vzalloc() (just like vmalloc()) returns
> a void*, so no reason to cast it.
>
> --
> Johannes Thumshirn SUSE Labs
> jthumshirn@suse.de +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
I will remove it and send v2
next prev parent reply other threads:[~2018-11-13 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 15:08 [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc Sabyasachi Gupta
2018-11-13 15:44 ` John Garry
2018-11-13 15:53 ` Johannes Thumshirn
2018-11-13 16:04 ` Sabyasachi Gupta [this message]
2018-11-13 16:11 ` James Bottomley
2018-11-13 16:16 ` Johannes Thumshirn
2018-11-13 16:22 ` Sabyasachi Gupta
2018-11-13 16:25 ` Johannes Thumshirn
2018-11-14 10:44 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJr6mf1Og4uNG3gOu56EBrm+2MQGg9=SZ2mCn9hQ=+8Er-WkBw@mail.gmail.com' \
--to=sabyasachi.linux@gmail.com \
--cc=brajeswar.linux@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=jrdr.linux@gmail.com \
--cc=jthumshirn@suse.de \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).