From: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
To: satishkh@cisco.com, sebaddel@cisco.com, kartilak@cisco.com,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Brajeswar Ghosh <brajeswar.linux@gmail.com>
Subject: Re: [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
Date: Wed, 5 Dec 2018 10:07:51 +0530 [thread overview]
Message-ID: <CAJr6mf1wqNq02e89U85u=h1Ge0MSzAOk+wQc9q_gWurEZzWZUw@mail.gmail.com> (raw)
In-Reply-To: <CAJr6mf1d=tviauDfd4Hq_750mGiypheUxHhQEv_tsdR_TrTkNA@mail.gmail.com>
On Fri, Nov 23, 2018 at 8:13 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> On Wed, Nov 14, 2018 at 10:24 PM Sabyasachi Gupta
> <sabyasachi.linux@gmail.com> wrote:
> >
> > Replaced vmalloc + memset with vzalloc
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
>
> Any comment on this patch?
Any comment on this patch?
>
> > ---
> > v2: Removed additional braces
> >
> > drivers/scsi/fnic/fnic_trace.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
> > index 8271785..bf0fd2a 100644
> > --- a/drivers/scsi/fnic/fnic_trace.c
> > +++ b/drivers/scsi/fnic/fnic_trace.c
> > @@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
> > fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
> > FNIC_ENTRY_SIZE_BYTES;
> >
> > - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
> > + fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
> > if (!fnic_trace_buf_p) {
> > printk(KERN_ERR PFX "Failed to allocate memory "
> > "for fnic_trace_buf_p\n");
> > err = -ENOMEM;
> > goto err_fnic_trace_buf_init;
> > }
> > - memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
> >
> > fnic_trace_entries.page_offset =
> > vmalloc(array_size(fnic_max_trace_entries,
> > --
> > 2.7.4
> >
next prev parent reply other threads:[~2018-12-05 4:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 16:54 [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc Sabyasachi Gupta
2018-11-23 14:43 ` Sabyasachi Gupta
2018-12-05 4:37 ` Sabyasachi Gupta [this message]
2018-12-05 6:30 ` Sesidhar Baddela (sebaddel)
2018-12-08 2:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJr6mf1wqNq02e89U85u=h1Ge0MSzAOk+wQc9q_gWurEZzWZUw@mail.gmail.com' \
--to=sabyasachi.linux@gmail.com \
--cc=brajeswar.linux@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jrdr.linux@gmail.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).