From: Roman Penyaev <roman.penyaev@profitbricks.com>
To: "Theodore Ts'o" <tytso@mit.edu>,
Roman Penyaev <roman.penyaev@profitbricks.com>,
Namjae Jeon <namjae.jeon@samsung.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents() using binsearch
Date: Fri, 6 Jan 2017 21:21:19 +0100 [thread overview]
Message-ID: <CAJrWOzDDy+GETUTAiRT7Sunj_LK8A8Uq9Nodwd+UBFpvY2WsXg@mail.gmail.com> (raw)
In-Reply-To: <20170104235818.v3fwchrjnxnhuble@thunk.org>
On Thu, Jan 5, 2017 at 12:58 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> It looks like the original (before your patch) 1k failures due to a
> bug introduced via the block.git tree, which has since been fixed in
> Linus's mainline tree as of today. It wouldn't surprise me if the bug
> interacted poorly your changes, so things will probably better with
> your patches applied directly on top of the tip of Linus's tree.
>
> That being said, it looks like there were still regressions introduced
> on the 4k configuration, so I'm in the middle of rerunning my baseline
> and trying out your patches as well.
I found a bug in my third patch, where I try to optimize linear search.
I missed the fact, that ext4_ext_binsearch() searches for the closest
extent from the left, but this linear search code does search for closest
extent from the right.
I ran the 'kvm-xfstests.sh -c 4k -g auto' against b25ead75e7b6 4.10-rc2
with and without my changes. No failures.
1k configuration was run against latest Linus's mainline. Also no
regressions were found: these two "generic/270, generic/273" fail
regardless my changes.
I will resend the patchset without latest patch shortly.
--
Roman
prev parent reply other threads:[~2017-01-06 20:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 12:54 [PATCH 0/3] ext4: fallocate insert/collapse range fixes Roman Pen
2017-01-02 12:54 ` [PATCH 1/3] ext4: Include forgotten start block on fallocate insert range Roman Pen
2017-01-02 12:54 ` [PATCH 2/3] ext4: Do not populate extents tree with outdated offsets while shifting extents Roman Pen
2017-01-02 12:54 ` [PATCH 3/3] ext4: Find desired extent in ext4_ext_shift_extents() using binsearch Roman Pen
2017-01-03 14:40 ` Theodore Ts'o
2017-01-03 20:44 ` Roman Penyaev
2017-01-03 22:15 ` Theodore Ts'o
2017-01-04 18:32 ` Roman Penyaev
2017-01-04 23:58 ` Theodore Ts'o
2017-01-05 8:02 ` Roman Penyaev
2017-01-06 20:21 ` Roman Penyaev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJrWOzDDy+GETUTAiRT7Sunj_LK8A8Uq9Nodwd+UBFpvY2WsXg@mail.gmail.com \
--to=roman.penyaev@profitbricks.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).