From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A43C433FE for ; Sun, 3 Apr 2022 16:01:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359335AbiDCQDk (ORCPT ); Sun, 3 Apr 2022 12:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351647AbiDCQDi (ORCPT ); Sun, 3 Apr 2022 12:03:38 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 639F93980D; Sun, 3 Apr 2022 09:01:44 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id h63so8535779iof.12; Sun, 03 Apr 2022 09:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/KVd5HFtfdl/4YhzYTy1ARrs2qcreXKLJ20n7fqioxY=; b=Lc3foFpYddqhED8+lp1gUshprjqka20POXoZ1Fqvhx5Nuf5x+ISBeP4wT+FG5RetpP +LiHFJYLTcUeyRHXZoK/Fnxf4SzeKxG9hEvyNFvIlVHa/NDu8yAs+jOx/p8dbbPURno/ I+zZ9pyY9vPwheJIa8DuATLYb9+Pygcx3vyKwPrDZr6FmrT6YMBiZSVRpI37m+BVSgim 2QVaVx8PfrTW106nE4HAcyQNbop5Jbvu75mx2fPV48jft1UOsbVwYDhs36WntKG1fROW 0rhTSnw6KvbXpCIiZ6jbVmx6cd6y8kIzTlo+g66AjvKmslg+BngMJb+PDr7NZJrrHdqI +Znw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/KVd5HFtfdl/4YhzYTy1ARrs2qcreXKLJ20n7fqioxY=; b=ia5lT94sEhbhFXHJVGefJ/MLmoBe8kTz+CBuUYJVcyD/P+CQjLwzyZlQVSyQ119jfQ 52+F9LF1ixI23DXiXEPHK0I5Q9oL2tGwHYgnFDGZcL7E9MrUvB9hU/BsYVG42Nb4cc5b njVk3qZ6SH+RJeXhPuhOR3lRHHgP4gizofsKDV7V9F2YAme7hssOk76XOgtP+xH14XYE Gok+YAyU96VksY4Nrlh+lkvNTY61iFxUq8GVO6uZeQu/STH2DyANGEAW70GgMI1hGTRn YRMsFhf2dlYiUTQ4rV9oa+c0OtY6ToTO2c1vQYYcHieX/4R8uR7KGNggFRn/90yMlvv9 kV+w== X-Gm-Message-State: AOAM533ZLggng7YuY4xc6Fa900x6LH1GTa68LN6dVQZc2ScMvUnkwtJm rFi6vySE21k9sCr/a5xx/qYh7kD3gtSRF2lLyug= X-Google-Smtp-Source: ABdhPJwtM9rC5frTbOPfqFXajh8HCuXZAkrqVls+IUjlbS6KZoNTleMbBV69uFF+7VRl3sGXuqvc9T4HYSnSDMPqcSY= X-Received: by 2002:a5e:9302:0:b0:648:c246:291 with SMTP id k2-20020a5e9302000000b00648c2460291mr3654500iom.88.1649001703873; Sun, 03 Apr 2022 09:01:43 -0700 (PDT) MIME-Version: 1.0 References: <20220403131154.1267887-1-gch981213@gmail.com> <20220403131154.1267887-4-gch981213@gmail.com> <817dda10-39db-adfc-376d-a3d5e037937e@linaro.org> <06ef6b4b-c8e8-549b-54be-9eecf59a7757@linaro.org> In-Reply-To: <06ef6b4b-c8e8-549b-54be-9eecf59a7757@linaro.org> From: Chuanhong Guo Date: Mon, 4 Apr 2022 00:01:32 +0800 Message-ID: Subject: Re: [PATCH 3/4] dt-bindings: spi: add binding doc for spi-mtk-snfi To: Krzysztof Kozlowski Cc: Miquel Raynal , Mark Brown , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Richard Weinberger , Vignesh Raghavendra , Roger Quadros , Thomas Bogendoerfer , Cai Huoqing , Florian Fainelli , Colin Ian King , Wolfram Sang , Paul Cercueil , Pratyush Yadav , Yu Kuai , "open list:SPI SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list , "open list:NAND FLASH SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Sun, Apr 3, 2022 at 11:49 PM Krzysztof Kozlowski wrote: > [...] > >>> + > >>> + ecc-engine: > >> > >> The nand-chip.yaml defines a nand-ecc-engine, so how about using that > >> one? I know mtk-nand.txt uses ecc-engine, but for new schema better to > >> use properties from existing YAML. > > > > The ecc-engine code is shared between mtk_nand.c and this driver, and > > the property name is defined in the shared part. I left it as-is so that > > existing dt for mtk_nand doesn't break. > > This can be easily fixed with: > np = of_parse_phandle(of_node, "nand-ecc-engine", 0); > if (!np) { > /* Backwards compatible */ > np = of_parse_phandle(of_node, "ecc-engine", 0); > } > > I would like to avoid having one property in generic NAND schema and > keep adding something slightly different everywhere else. OK. I'll add a commit for this in the next version. -- Regards, Chuanhong Guo