From: Rob Clark <robdclark@chromium.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: Rob Clark <robdclark@gmail.com>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
freedreno <freedreno@lists.freedesktop.org>,
Rajesh Yadav <ryadav@codeaurora.org>,
Boris Brezillon <bbrezillon@kernel.org>,
David Airlie <airlied@linux.ie>,
MSM <linux-arm-msm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Mamta Shukla <mamtashukla555@gmail.com>,
Sean Paul <seanpaul@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>, Sean Paul <sean@poorly.run>,
Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [Freedreno] [PATCH 5/5] drm/msm/mdp5: Use the interconnect API
Date: Tue, 18 Jun 2019 14:17:16 -0700 [thread overview]
Message-ID: <CAJs_Fx4ys6CsgfrLHsU_8DKmgNAB6DbF+AQaHOJzwfzMFKj-Tw@mail.gmail.com> (raw)
In-Reply-To: <CAOCk7NoTN6JEo7B=8P=T4C3t_Xr8eQUX=KG9j4N+jXZ8Pw2f4g@mail.gmail.com>
On Tue, Jun 18, 2019 at 1:44 PM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
>
> On Tue, Jun 18, 2019 at 2:25 PM Rob Clark <robdclark@gmail.com> wrote:
> >
> > From: Georgi Djakov <georgi.djakov@linaro.org>
> >
> > The interconnect API provides an interface for consumer drivers to
> > express their bandwidth needs in the SoC. This data is aggregated
> > and the on-chip interconnect hardware is configured to the most
> > appropriate power/performance profile.
> >
> > Use the API to configure the interconnects and request bandwidth
> > between DDR and the display hardware (MDP port(s) and rotator
> > downscaler).
> >
> > v2: update the path names to be consistent with dpu, handle the NULL
> > path case, updated commit msg from Georgi.
> >
> > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> > index 97179bec8902..eeac429acf40 100644
> > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
> > @@ -16,6 +16,7 @@
> > * this program. If not, see <http://www.gnu.org/licenses/>.
> > */
> >
> > +#include <linux/interconnect.h>
> > #include <linux/of_irq.h>
> >
> > #include "msm_drv.h"
> > @@ -1050,6 +1051,19 @@ static const struct component_ops mdp5_ops = {
> >
> > static int mdp5_dev_probe(struct platform_device *pdev)
> > {
> > + struct icc_path *path0 = of_icc_get(&pdev->dev, "mdp0-mem");
> > + struct icc_path *path1 = of_icc_get(&pdev->dev, "mdp1-mem");
> > + struct icc_path *path_rot = of_icc_get(&pdev->dev, "rotator-mem");
> > +
> > + if (IS_ERR_OR_NULL(path0))
> > + return PTR_ERR_OR_ZERO(path0);
>
> Umm, am I misunderstanding something? It seems like of_icc_get()
> returns NULL if the property doesn't exist. Won't this be backwards
> incompatible? Existing DTs won't specify the property, and I don't
> believe the property is supported on all targets. Seems like we'll
> break things by not calling the below component_add() if the
> interconnect is not supported, specified, or the interconnect driver
> is not compiled.
hmm, right, I guess I should test this w/out the dts patch.. probably
should just revert back to the previous logic..
BR,
-R
> > + icc_set_bw(path0, 0, MBps_to_icc(6400));
> > +
> > + if (!IS_ERR_OR_NULL(path1))
> > + icc_set_bw(path1, 0, MBps_to_icc(6400));
> > + if (!IS_ERR_OR_NULL(path_rot))
> > + icc_set_bw(path_rot, 0, MBps_to_icc(6400));
> > +
> > DBG("");
> > return component_add(&pdev->dev, &mdp5_ops);
> > }
> > --
> > 2.20.1
> >
> > _______________________________________________
> > Freedreno mailing list
> > Freedreno@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/freedreno
next prev parent reply other threads:[~2019-06-18 21:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190618202425.15259-1-robdclark@gmail.com>
2019-06-18 20:24 ` [PATCH 1/5] drm/msm/dpu: clean up references of DPU custom bus scaling Rob Clark
2019-06-18 20:39 ` Sean Paul
2019-06-18 20:24 ` [PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS Rob Clark
2019-06-18 20:42 ` Sean Paul
2019-06-18 20:24 ` [PATCH 3/5] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845 Rob Clark
2019-06-18 20:24 ` [PATCH 4/5] drm/msm/dpu: add icc voting in dpu_mdss_init Rob Clark
2019-06-18 20:24 ` [PATCH 5/5] drm/msm/mdp5: Use the interconnect API Rob Clark
2019-06-18 20:44 ` [Freedreno] " Jeffrey Hugo
2019-06-18 21:17 ` Rob Clark [this message]
2019-06-18 22:10 ` [PATCH 5/5 v3] " Rob Clark
2019-06-20 14:48 ` [Freedreno] " Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJs_Fx4ys6CsgfrLHsU_8DKmgNAB6DbF+AQaHOJzwfzMFKj-Tw@mail.gmail.com \
--to=robdclark@chromium.org \
--cc=airlied@linux.ie \
--cc=bbrezillon@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mamtashukla555@gmail.com \
--cc=robdclark@gmail.com \
--cc=ryadav@codeaurora.org \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).