From: Suren Baghdasaryan <surenb@google.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>, Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>,
Matthew Wilcox <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Rik van Riel <riel@surriel.com>,
Minchan Kim <minchan@kernel.org>,
Christian Brauner <christian@brauner.io>,
Christoph Hellwig <hch@infradead.org>,
Oleg Nesterov <oleg@redhat.com>,
David Hildenbrand <david@redhat.com>,
Jann Horn <jannh@google.com>, Shakeel Butt <shakeelb@google.com>,
Tim Murray <timmurray@google.com>,
Linux API <linux-api@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 1/1] mm: introduce process_reap system call
Date: Thu, 1 Jul 2021 16:08:01 -0700 [thread overview]
Message-ID: <CAJuCfpEWmcJSKuAD+4yOcWyTTDTo0p7Aico5FruXZcyZt120Jg@mail.gmail.com> (raw)
In-Reply-To: <CALCETrW7Mm6xNwdhsEd9LZFJNJ_5ZtBPfTiqs=np3V7cqo=cAA@mail.gmail.com>
)
On Wed, Jun 30, 2021 at 5:46 PM Andy Lutomirski <luto@kernel.org> wrote:
>
> On Wed, Jun 30, 2021 at 11:51 AM Suren Baghdasaryan <surenb@google.com> wrote:
> >
> > On Wed, Jun 30, 2021 at 11:26 AM Andy Lutomirski <luto@kernel.org> wrote:
> > >
> > > On Wed, Jun 23, 2021 at 12:28 PM Suren Baghdasaryan <surenb@google.com> wrote:
> > > >
> > > > In modern systems it's not unusual to have a system component monitoring
> > > > memory conditions of the system and tasked with keeping system memory
> > > > pressure under control. One way to accomplish that is to kill
> > > > non-essential processes to free up memory for more important ones.
> > > > Examples of this are Facebook's OOM killer daemon called oomd and
> > > > Android's low memory killer daemon called lmkd.
> > > > For such system component it's important to be able to free memory
> > > > quickly and efficiently. Unfortunately the time process takes to free
> > > > up its memory after receiving a SIGKILL might vary based on the state
> > > > of the process (uninterruptible sleep), size and OPP level of the core
> > > > the process is running. A mechanism to free resources of the target
> > > > process in a more predictable way would improve system's ability to
> > > > control its memory pressure.
> > > > Introduce process_reap system call that reclaims memory of a dying process
> > > > from the context of the caller. This way the memory in freed in a more
> > > > controllable way with CPU affinity and priority of the caller. The workload
> > > > of freeing the memory will also be charged to the caller.
> > > > The operation is allowed only on a dying process.
> > >
> > > At the risk of asking a potentially silly question, should this just
> > > be a file in procfs?
> >
> > Hmm. I guess it's doable if procfs will not disappear too soon before
> > memory is released... syscall also supports parameters, in this case
> > flags can be used in the future to support PIDs in addition to PIDFDs
> > for example.
> > Before looking more in that direction, a silly question from my side:
> > why procfs interface would be preferable to a syscall?
>
> It avoids using a syscall nr. (Admittedly a syscall nr is not *that*
> precious of a resource.) It also makes it possible to use a shell
> script to do this, which is maybe useful.
I see. Not really sure if the shell usage is a big usecase for this
operation but let's see if more people like that approach. For my
specific usecase one syscall (process_reap) is better than three
syscalls (open, write, close) and the possibility to extend the
functionality using flags might be of value for the future.
>
> --Andy
next prev parent reply other threads:[~2021-07-01 23:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 19:28 [PATCH 1/1] mm: introduce process_reap system call Suren Baghdasaryan
2021-06-23 19:34 ` Suren Baghdasaryan
2021-06-29 13:13 ` Christian Brauner
2021-06-29 16:15 ` Suren Baghdasaryan
2021-06-30 18:00 ` Shakeel Butt
2021-06-30 18:43 ` Suren Baghdasaryan
2021-06-30 19:00 ` Shakeel Butt
2021-06-30 19:06 ` Suren Baghdasaryan
2021-06-30 18:26 ` Andy Lutomirski
2021-06-30 18:51 ` Suren Baghdasaryan
2021-06-30 21:45 ` Johannes Weiner
2021-07-01 0:44 ` Andy Lutomirski
2021-07-01 22:59 ` Suren Baghdasaryan
2021-07-02 15:27 ` Christian Brauner
2021-07-05 7:41 ` David Hildenbrand
2021-07-07 12:38 ` Michal Hocko
2021-07-07 21:14 ` Suren Baghdasaryan
2021-07-09 8:58 ` Christian Brauner
2021-07-09 20:05 ` Suren Baghdasaryan
2021-07-01 0:45 ` Andy Lutomirski
2021-07-01 23:08 ` Suren Baghdasaryan [this message]
2021-07-07 9:46 ` Florian Weimer
2021-07-07 21:07 ` Suren Baghdasaryan
2021-07-08 5:40 ` Florian Weimer
2021-07-08 6:05 ` Suren Baghdasaryan
2021-07-08 6:14 ` Florian Weimer
2021-07-08 6:39 ` Suren Baghdasaryan
2021-07-08 7:13 ` Florian Weimer
2021-07-12 12:51 ` Jan Engelhardt
2021-07-12 18:39 ` Suren Baghdasaryan
2021-07-12 19:16 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJuCfpEWmcJSKuAD+4yOcWyTTDTo0p7Aico5FruXZcyZt120Jg@mail.gmail.com \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=christian@brauner.io \
--cc=david@redhat.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=jannh@google.com \
--cc=kernel-team@android.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=oleg@redhat.com \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=timmurray@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).