From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B4CC433E0 for ; Mon, 3 Aug 2020 16:00:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C735420825 for ; Mon, 3 Aug 2020 16:00:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gP0hGxdZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728290AbgHCQAO (ORCPT ); Mon, 3 Aug 2020 12:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgHCQAO (ORCPT ); Mon, 3 Aug 2020 12:00:14 -0400 Received: from mail-vk1-xa41.google.com (mail-vk1-xa41.google.com [IPv6:2607:f8b0:4864:20::a41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 039BBC06179E for ; Mon, 3 Aug 2020 09:00:14 -0700 (PDT) Received: by mail-vk1-xa41.google.com with SMTP id i20so3335vkk.2 for ; Mon, 03 Aug 2020 09:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AQC5OSI+ot4HICgMI1hBiF+Gos4KF9rtoTAXqBLWz5k=; b=gP0hGxdZpv7oi/HJF0iairUbhXDSeECExkx/WUmvKbJIKYqRHFbhrSant0W/qarBAu pt2QS00SD0C3sScBrjjH8PuJSo/uiRusGI8NdinY72x5wOlbs+la767nkgtU1+AdO/4R sVgh/KH5EXT8KXDfD+VCxBTK4X1AEadmwBpBrMVvntYBujslfuoMPSdeAJPR+0zoXtmU az8f0YQ3IGNq2/+IKVQAVs5iYU/bcziJbdbgOWftXf0g+mybpPTS5/8EnV/nQwq4dSqm ZRV9gMwTdIcvKiJF/9J0XUaNMTR7Pm4yz/Nv7W/qKW98y0pV5r5ge3KKLHyEx2GZZhW8 O0Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AQC5OSI+ot4HICgMI1hBiF+Gos4KF9rtoTAXqBLWz5k=; b=GYnTm6lBWH8cTY6PZ59CmIIBa6ggKwQOXCpgWobzQGkZ8mPOkehtQuuXKgSveGrvj9 jBTW7VkAg+CcWGLAtIAwUTLkUEMfNI/UUbBHjgDmbrV+WBUmIuE1DOeMucYMTKsUzWaD bMRFInYZPYBFbTxUAOpeINsWvociUQZryxT/RWaAOT7DpP7/sDrzAskaRHxuRsEfXjfj XSWk/iosJnglaHPK5Rhc3OQ7xFuQbMx2flctnd6aZImy4KC7rdfLZ/sRG/fIWSCXslGW ivsKF5tTDmFj5uMBUjaMRyGhBduhSJxXoFTJyEG6HFQ10b7BZWZRY/dCXtEpW23cOcWY Kw1Q== X-Gm-Message-State: AOAM531XHAezZj16Ct9mif0I2/M/lUIBQDN/RP1I1LfKwH8hsL216tVf CtLNiXUGqvroAmX/Ztvbxq0nNPPAeZxkR9DAoXf7Mw== X-Google-Smtp-Source: ABdhPJxBkWFzXg/y1w5xTYtUJSHjvCQFO/a1nE0RcfXFpI2HgJqGujkazyU0S+p/ymKJ5J9VS+bR1YpMln1PD/g9du0= X-Received: by 2002:a1f:9651:: with SMTP id y78mr1828501vkd.5.1596470412618; Mon, 03 Aug 2020 09:00:12 -0700 (PDT) MIME-Version: 1.0 References: <20200803144719.3184138-1-kaleshsingh@google.com> <20200803144719.3184138-3-kaleshsingh@google.com> <20200803154125.GA23808@casper.infradead.org> In-Reply-To: <20200803154125.GA23808@casper.infradead.org> From: Suren Baghdasaryan Date: Mon, 3 Aug 2020 09:00:00 -0700 Message-ID: Subject: Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events To: Matthew Wilcox Cc: Kalesh Singh , Jonathan Corbet , Sumit Semwal , Alexander Viro , Steven Rostedt , Ingo Molnar , linux-doc@vger.kernel.org, LKML , linux-media@vger.kernel.org, DRI mailing list , linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, Hridya Valsaraju , Ioannis Ilkos , John Stultz , kernel-team Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 3, 2020 at 8:41 AM Matthew Wilcox wrote: > > On Mon, Aug 03, 2020 at 02:47:19PM +0000, Kalesh Singh wrote: > > +static void dma_buf_fd_install(int fd, struct file *filp) > > +{ > > + trace_dma_buf_fd_ref_inc(current, filp); > > +} > > You're adding a new file_operation in order to just add a new tracepoint? > NACK. Hi Matthew, The plan is to attach a BPF to this tracepoint in order to track dma-buf users. If you feel this is an overkill, what would you suggest as an alternative?