From: Suren Baghdasaryan <surenb@google.com> To: Patrick Bellasi <patrick.bellasi@arm.com> Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Viresh Kumar <viresh.kumar@linaro.org>, Vincent Guittot <vincent.guittot@linaro.org>, Paul Turner <pjt@google.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Morten Rasmussen <morten.rasmussen@arm.com>, Juri Lelli <juri.lelli@redhat.com>, Todd Kjos <tkjos@google.com>, Joel Fernandes <joelaf@google.com>, Steve Muckle <smuckle@google.com> Subject: Re: [PATCH v2 11/12] sched/core: uclamp: update CPU's refcount on TG's clamp changes Date: Sat, 21 Jul 2018 20:17:57 -0700 [thread overview] Message-ID: <CAJuCfpFdxG=1hELqg4MQoKfRCTDCGCkuvkRS=QdYAjdkU=r_8Q@mail.gmail.com> (raw) In-Reply-To: <20180716082906.6061-12-patrick.bellasi@arm.com> On Mon, Jul 16, 2018 at 1:29 AM, Patrick Bellasi <patrick.bellasi@arm.com> wrote: > When a task group refcounts a new clamp group, we need to ensure that > the new clamp values are immediately enforced to all its tasks which are > currently RUNNABLE. This is to ensure that all currently RUNNABLE task tasks > are boosted and/or clamped as requested as soon as possible. > > Let's ensure that, whenever a new clamp group is refcounted by a task > group, all its RUNNABLE tasks are correctly accounted in their > respective CPUs. We do that by slightly refactoring uclamp_group_get() > to get an additional parameter *cgroup_subsys_state which, when > provided, it's used to walk the list of tasks in the correspond TGs and corresponding TGs > update the RUNNABLE ones. > > This is a "brute force" solution which allows to reuse the same refcount > update code already used by the per-task API. That's also the only way > to ensure a prompt enforcement of new clamp constraints on RUNNABLE > tasks, as soon as a task group attribute is tweaked. > > Signed-off-by: Patrick Bellasi <patrick.bellasi@arm.com> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Tejun Heo <tj@kernel.org> > Cc: Paul Turner <pjt@google.com> > Cc: Todd Kjos <tkjos@google.com> > Cc: Joel Fernandes <joelaf@google.com> > Cc: Steve Muckle <smuckle@google.com> > Cc: Juri Lelli <juri.lelli@redhat.com> > Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> > Cc: Morten Rasmussen <morten.rasmussen@arm.com> > Cc: linux-kernel@vger.kernel.org > Cc: linux-pm@vger.kernel.org > --- > kernel/sched/core.c | 42 ++++++++++++++++++++++++++++++++++-------- > 1 file changed, 34 insertions(+), 8 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 50613d3d5b83..42cff5ffddae 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1198,21 +1198,43 @@ static inline void uclamp_group_put(int clamp_id, int group_id) > raw_spin_unlock_irqrestore(&uc_map[group_id].se_lock, flags); > } > > +static inline void uclamp_group_get_tg(struct cgroup_subsys_state *css, > + int clamp_id, unsigned int group_id) > +{ > + struct css_task_iter it; > + struct task_struct *p; > + > + /* Update clamp groups for RUNNABLE tasks in this TG */ > + css_task_iter_start(css, 0, &it); > + while ((p = css_task_iter_next(&it))) > + uclamp_task_update_active(p, clamp_id, group_id); > + css_task_iter_end(&it); > +} > + > /** > * uclamp_group_get: increase the reference count for a clamp group > * @p: the task which clamp value must be tracked > - * @clamp_id: the clamp index affected by the task > - * @uc_se: the utilization clamp data for the task > - * @clamp_value: the new clamp value for the task > + * @css: the task group which clamp value must be tracked > + * @clamp_id: the clamp index affected by the task (group) > + * @uc_se: the utilization clamp data for the task (group) > + * @clamp_value: the new clamp value for the task (group) > * > * Each time a task changes its utilization clamp value, for a specified clamp > * index, we need to find an available clamp group which can be used to track > * this new clamp value. The corresponding clamp group index will be used by > * the task to reference count the clamp value on CPUs while enqueued. > * > + * When the cgroup's cpu controller utilization clamping support is enabled, > + * each task group has a set of clamp values which are used to restrict the > + * corresponding task specific clamp values. > + * When a clamp value for a task group is changed, all the (active) tasks > + * belonging to that task group must be update to ensure they are refcounting must be updated > + * the correct CPU's clamp value. > + * > * Return: -ENOSPC if there are no available clamp groups, 0 on success. > */ > static inline int uclamp_group_get(struct task_struct *p, > + struct cgroup_subsys_state *css, > int clamp_id, struct uclamp_se *uc_se, > unsigned int clamp_value) > { > @@ -1240,6 +1262,10 @@ static inline int uclamp_group_get(struct task_struct *p, > uc_map[next_group_id].se_count += 1; > raw_spin_unlock_irqrestore(&uc_map[next_group_id].se_lock, flags); > > + /* Newly created TG don't have tasks assigned */ > + if (css) > + uclamp_group_get_tg(css, clamp_id, next_group_id); > + > /* Update CPU's clamp group refcounts of RUNNABLE task */ > if (p) > uclamp_task_update_active(p, clamp_id, next_group_id); > @@ -1307,7 +1333,7 @@ static inline int alloc_uclamp_sched_group(struct task_group *tg, > uc_se->value = parent->uclamp[clamp_id].value; > uc_se->group_id = UCLAMP_NONE; > > - if (uclamp_group_get(NULL, clamp_id, uc_se, > + if (uclamp_group_get(NULL, NULL, clamp_id, uc_se, > parent->uclamp[clamp_id].value)) { > ret = 0; > goto out; > @@ -1362,12 +1388,12 @@ static inline int __setscheduler_uclamp(struct task_struct *p, > > /* Update min utilization clamp */ > uc_se = &p->uclamp[UCLAMP_MIN]; > - retval |= uclamp_group_get(p, UCLAMP_MIN, uc_se, > + retval |= uclamp_group_get(p, NULL, UCLAMP_MIN, uc_se, > attr->sched_util_min); > > /* Update max utilization clamp */ > uc_se = &p->uclamp[UCLAMP_MAX]; > - retval |= uclamp_group_get(p, UCLAMP_MAX, uc_se, > + retval |= uclamp_group_get(p, NULL, UCLAMP_MAX, uc_se, > attr->sched_util_max); > > mutex_unlock(&uclamp_mutex); > @@ -7274,7 +7300,7 @@ static int cpu_util_min_write_u64(struct cgroup_subsys_state *css, > > /* Update TG's reference count */ > uc_se = &tg->uclamp[UCLAMP_MIN]; > - ret = uclamp_group_get(NULL, UCLAMP_MIN, uc_se, min_value); > + ret = uclamp_group_get(NULL, css, UCLAMP_MIN, uc_se, min_value); > > out: > rcu_read_unlock(); > @@ -7306,7 +7332,7 @@ static int cpu_util_max_write_u64(struct cgroup_subsys_state *css, > > /* Update TG's reference count */ > uc_se = &tg->uclamp[UCLAMP_MAX]; > - ret = uclamp_group_get(NULL, UCLAMP_MAX, uc_se, max_value); > + ret = uclamp_group_get(NULL, css, UCLAMP_MAX, uc_se, max_value); > > out: > rcu_read_unlock(); > -- > 2.17.1 >
next prev parent reply other threads:[~2018-07-22 3:18 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-16 8:28 [PATCH v2 00/12] Add utilization clamping support Patrick Bellasi 2018-07-16 8:28 ` [PATCH v2 01/12] sched/core: uclamp: extend sched_setattr to support utilization clamping Patrick Bellasi 2018-07-17 17:50 ` Joel Fernandes 2018-07-18 8:42 ` Patrick Bellasi 2018-07-18 17:02 ` Joel Fernandes 2018-07-17 18:04 ` Joel Fernandes 2018-07-16 8:28 ` [PATCH v2 02/12] sched/core: uclamp: map TASK's clamp values into CPU's clamp groups Patrick Bellasi 2018-07-19 23:51 ` Suren Baghdasaryan 2018-07-20 15:11 ` Patrick Bellasi 2018-07-21 0:25 ` Suren Baghdasaryan 2018-07-23 13:36 ` Patrick Bellasi 2018-07-16 8:28 ` [PATCH v2 03/12] sched/core: uclamp: add CPU's clamp groups accounting Patrick Bellasi 2018-07-20 20:25 ` Suren Baghdasaryan 2018-07-16 8:28 ` [PATCH v2 04/12] sched/core: uclamp: update CPU's refcount on clamp changes Patrick Bellasi 2018-07-16 8:28 ` [PATCH v2 05/12] sched/cpufreq: uclamp: add utilization clamping for FAIR tasks Patrick Bellasi 2018-07-16 8:29 ` [PATCH v2 06/12] sched/cpufreq: uclamp: add utilization clamping for RT tasks Patrick Bellasi 2018-07-16 8:29 ` [PATCH v2 07/12] sched/core: uclamp: enforce last task UCLAMP_MAX Patrick Bellasi 2018-07-21 1:23 ` Suren Baghdasaryan 2018-07-23 15:02 ` Patrick Bellasi 2018-07-23 16:40 ` Suren Baghdasaryan 2018-07-16 8:29 ` [PATCH v2 08/12] sched/core: uclamp: extend cpu's cgroup controller Patrick Bellasi 2018-07-21 2:37 ` Suren Baghdasaryan 2018-07-21 3:16 ` Suren Baghdasaryan 2018-07-23 15:17 ` Patrick Bellasi 2018-07-23 15:30 ` Tejun Heo 2018-07-23 17:22 ` Patrick Bellasi 2018-07-24 13:29 ` Tejun Heo 2018-07-24 15:39 ` Patrick Bellasi 2018-07-27 0:39 ` Joel Fernandes 2018-07-27 8:09 ` Quentin Perret 2018-07-16 8:29 ` [PATCH v2 09/12] sched/core: uclamp: map TG's clamp values into CPU's clamp groups Patrick Bellasi 2018-07-16 8:29 ` [PATCH v2 10/12] sched/core: uclamp: use TG's clamps to restrict Task's clamps Patrick Bellasi 2018-07-22 3:05 ` Suren Baghdasaryan 2018-07-23 15:40 ` Patrick Bellasi 2018-07-23 17:11 ` Suren Baghdasaryan 2018-07-24 9:56 ` Patrick Bellasi 2018-07-24 15:28 ` Suren Baghdasaryan 2018-07-24 15:49 ` Patrick Bellasi 2018-07-16 8:29 ` [PATCH v2 11/12] sched/core: uclamp: update CPU's refcount on TG's clamp changes Patrick Bellasi 2018-07-22 3:17 ` Suren Baghdasaryan [this message] 2018-07-16 8:29 ` [PATCH v2 12/12] sched/core: uclamp: use percentage clamp values Patrick Bellasi 2018-07-22 4:04 ` Suren Baghdasaryan 2018-07-24 16:43 ` Patrick Bellasi 2018-07-24 17:11 ` Suren Baghdasaryan 2018-07-24 17:17 ` Patrick Bellasi 2018-07-17 13:03 ` [PATCH v2 00/12] Add utilization clamping support Joel Fernandes 2018-07-17 13:41 ` Patrick Bellasi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJuCfpFdxG=1hELqg4MQoKfRCTDCGCkuvkRS=QdYAjdkU=r_8Q@mail.gmail.com' \ --to=surenb@google.com \ --cc=dietmar.eggemann@arm.com \ --cc=joelaf@google.com \ --cc=juri.lelli@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=morten.rasmussen@arm.com \ --cc=patrick.bellasi@arm.com \ --cc=peterz@infradead.org \ --cc=pjt@google.com \ --cc=rafael.j.wysocki@intel.com \ --cc=smuckle@google.com \ --cc=tj@kernel.org \ --cc=tkjos@google.com \ --cc=vincent.guittot@linaro.org \ --cc=viresh.kumar@linaro.org \ --subject='Re: [PATCH v2 11/12] sched/core: uclamp: update CPU'\''s refcount on TG'\''s clamp changes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).