From: Suren Baghdasaryan <surenb@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Shakeel Butt <shakeelb@google.com>,
Rik van Riel <riel@surriel.com>, Michal Hocko <mhocko@suse.com>,
linux-mm <linux-mm@kvack.org>,
cgroups mailinglist <cgroups@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-team@fb.com
Subject: Re: [PATCH 3/3] mm: vmscan: enforce inactive:active ratio at the reclaim root
Date: Tue, 12 Nov 2019 12:34:03 -0800 [thread overview]
Message-ID: <CAJuCfpFtJcp8Ry7eC=1SbQwn2rgxvKO1Ej_QjxBxEPY_dYsjBg@mail.gmail.com> (raw)
In-Reply-To: <CAJuCfpFJ-tzqc6Ng-6ntQn46iatgOdLF5PY6WAcOHVvGSQGwMg@mail.gmail.com>
On Tue, Nov 12, 2019 at 11:13 AM Suren Baghdasaryan <surenb@google.com> wrote:
>
> On Tue, Nov 12, 2019 at 10:00 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
> >
> > On Sun, Nov 10, 2019 at 06:15:50PM -0800, Suren Baghdasaryan wrote:
> > > On Thu, Nov 7, 2019 at 12:53 PM Johannes Weiner <hannes@cmpxchg.org> wrote:
> > > > @@ -2758,7 +2775,17 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
> > > > total_high_wmark += high_wmark_pages(zone);
> > > > }
> > > >
> > > > - sc->file_is_tiny = file + free <= total_high_wmark;
> > > > + /*
> > > > + * Consider anon: if that's low too, this isn't a
> > > > + * runaway file reclaim problem, but rather just
> > > > + * extreme pressure. Reclaim as per usual then.
> > > > + */
> > > > + anon = node_page_state(pgdat, NR_INACTIVE_ANON);
> > > > +
> > > > + sc->file_is_tiny =
> > > > + file + free <= total_high_wmark &&
> > > > + !(sc->may_deactivate & DEACTIVATE_ANON) &&
> > > > + anon >> sc->priority;
> > >
> > > The name of file_is_tiny flag seems to not correspond with its actual
> > > semantics anymore. Maybe rename it into "skip_file"?
> >
> > I'm not a fan of file_is_tiny, but I also don't like skip_file. IMO
> > it's better to have it describe a situation instead of an action, in
> > case we later want to take additional action for that situation.
> >
> > Any other ideas? ;)
>
> All other ideas still yield verbs (like sc->prefer_anon). Maybe then
> add some comment at the file_is_tiny declaration that it represents
> not only the fact that the file LRU is too small to reclaim but also
> that there are easily reclaimable anon pages?
>
> >
> > > I'm confused about why !(sc->may_deactivate & DEACTIVATE_ANON) should
> > > be a prerequisite for skipping file LRU reclaim. IIUC this means we
> > > will skip reclaiming from file LRU only when anonymous page
> > > deactivation is not allowed. Could you please add a comment explaining
> > > this?
> >
> > The comment above this check tries to explain it: the definition of
> > file being "tiny" is dependent on the availability of anon. It's a
> > relative comparison.
> >
> > If file only has a few pages, and anon is easily reclaimable (does not
> > require deactivation to reclaim pages), then file is "tiny" and we
> > should go after the more plentiful anon pages.
>
> Your above explanation is much clearer to me than the one in the comment :)
>
> >
> > If anon is under duress, too, this preference doesn't make sense and
> > we should just reclaim both lists equally, as per usual.
> >
> > Note that I'm not introducing this constraint, I'm just changing how
> > it's implemented. From the patch:
> >
> > > > /*
> > > > * If the system is almost out of file pages, force-scan anon.
> > > > - * But only if there are enough inactive anonymous pages on
> > > > - * the LRU. Otherwise, the small LRU gets thrashed.
> > > > */
> > > > - if (sc->file_is_tiny &&
> > > > - !inactive_list_is_low(lruvec, false, sc, false) &&
> > > > - lruvec_lru_size(lruvec, LRU_INACTIVE_ANON,
> > > > - sc->reclaim_idx) >> sc->priority) {
> > > > + if (sc->file_is_tiny) {
> > > > scan_balance = SCAN_ANON;
> > > > goto out;
> > > > }
> >
> > So it's always been checking whether reclaim would deactivate anon,
> > and whether inactive_anon has sufficient pages for this priority.
>
> I didn't realize !inactive_list_is_low(lruvec, false, sc, false) is
> effectively the same as !(sc->may_deactivate & DEACTIVATE_ANON) but
> after re-reading the patch that makes sense... Except when
> force_deactivate==true, in which case shouldn't you consider
> NR_ACTIVE_ANON as easily reclaimable too? IOW should it be smth like
> this:
>
> anon = node_page_state(pgdat, NR_INACTIVE_ANON) +
> (sc->force_deactivate ? node_page_state(pgdat, NR_ACTIVE_ANON) : 0);
>
> ?
On second thought that proposal would not be correct since
deactivation is not the same as reclaim... So the way it is now looks
correct.
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
next prev parent reply other threads:[~2019-11-12 20:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 20:53 [PATCH 0/3] mm: fix page aging across multiple cgroups Johannes Weiner
2019-11-07 20:53 ` [PATCH 1/3] mm: vmscan: move file exhaustion detection to the node level Johannes Weiner
2019-11-10 22:02 ` Suren Baghdasaryan
2019-11-07 20:53 ` [PATCH 2/3] mm: vmscan: detect file thrashing at the reclaim root Johannes Weiner
2019-11-11 2:01 ` Suren Baghdasaryan
2019-11-12 17:45 ` Johannes Weiner
2019-11-12 18:45 ` Suren Baghdasaryan
2019-11-12 18:59 ` Johannes Weiner
2019-11-12 20:35 ` Suren Baghdasaryan
2019-11-14 23:47 ` Shakeel Butt
2019-11-15 16:07 ` Johannes Weiner
2019-11-15 16:52 ` Shakeel Butt
2020-02-12 10:28 ` Joonsoo Kim
2020-02-12 18:18 ` Johannes Weiner
2020-02-14 1:17 ` Joonsoo Kim
2019-11-07 20:53 ` [PATCH 3/3] mm: vmscan: enforce inactive:active ratio " Johannes Weiner
2019-11-11 2:15 ` Suren Baghdasaryan
2019-11-12 18:00 ` Johannes Weiner
2019-11-12 19:13 ` Suren Baghdasaryan
2019-11-12 20:34 ` Suren Baghdasaryan [this message]
2019-11-15 0:29 ` Shakeel Butt
2019-11-27 22:16 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpFtJcp8Ry7eC=1SbQwn2rgxvKO1Ej_QjxBxEPY_dYsjBg@mail.gmail.com' \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).