From: Suren Baghdasaryan <surenb@google.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Michal Hocko <mhocko@suse.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Christian Brauner <christian.brauner@ubuntu.com>,
Tim Murray <timmurray@google.com>,
mingo@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
esyr@redhat.com, christian@kellner.me, areber@redhat.com,
Shakeel Butt <shakeelb@google.com>,
cyphar@cyphar.com, adobriyan@gmail.com,
Andrew Morton <akpm@linux-foundation.org>,
gladkov.alexey@gmail.com, Michel Lespinasse <walken@google.com>,
daniel.m.jordan@oracle.com, avagin@gmail.com,
bernd.edlinger@hotmail.de,
John Johansen <john.johansen@canonical.com>,
laoar.shao@gmail.com, Minchan Kim <minchan@kernel.org>,
kernel-team <kernel-team@android.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 1/1] mm, oom_adj: don't loop through tasks in __set_oom_adj when not necessary
Date: Fri, 21 Aug 2020 09:06:14 -0700 [thread overview]
Message-ID: <CAJuCfpG06_KLhQyg9N84bRQOdvG27uAZ2oBDEQPR-OnZeNJd1w@mail.gmail.com> (raw)
In-Reply-To: <CAJuCfpF_GhTy5SCjxqyqTFUrJNaw3UGJzCi=WSCXfqPAcbThYg@mail.gmail.com>
On Fri, Aug 21, 2020 at 8:28 AM Suren Baghdasaryan <surenb@google.com> wrote:
>
> On Fri, Aug 21, 2020 at 4:16 AM Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > On 08/20, Eric W. Biederman wrote:
> > >
> > > That said if we are going for a small change why not:
> > >
> > > /*
> > > * Make sure we will check other processes sharing the mm if this is
> > > * not vfrok which wants its own oom_score_adj.
> > > * pin the mm so it doesn't go away and get reused after task_unlock
> > > */
> > > if (!task->vfork_done) {
> > > struct task_struct *p = find_lock_task_mm(task);
> > >
> > > if (p) {
> > > - if (atomic_read(&p->mm->mm_users) > 1) {
> > > + if (atomic_read(&p->mm->mm_users) > p->signal->nr_threads) {
> >
> > In theory this needs a barrier to avoid the race with do_exit(). And I'd
> > suggest to use signal->live, I think signal->nr_threads should die...
> > Something like
> >
> > bool probably_has_other_mm_users(tsk)
> > {
> > return atomic_read_acquire(&tsk->mm->mm_users) >
> > atomic_read(&tsk->signal->live);
> > }
> >
> > The barrier implied by _acquire ensures that if we race with the exiting
> > task and see the result of exit_mm()->mmput(mm), then we must also see
> > the result of atomic_dec_and_test(signal->live).
> >
> > Either way, if we want to fix the race with clone(CLONE_VM) we need other
> > changes.
>
> The way I understand this condition in __set_oom_adj() sync logic is
> that we would be ok with false positives (when we loop unnecessarily)
> but we can't tolerate false negatives (when oom_score_adj gets out of
> sync). With the clone(CLONE_VM) race not addressed we are allowing
> false negatives and IMHO that's not acceptable because it creates a
> possibility for userspace to get an inconsistent picture. When
> developing the patch I did think about using (p->mm->mm_users >
> p->signal->nr_threads) condition and had to reject it due to that
> reason.
>
Actually, reviewing again and considering where list_add_tail_rcu is
happening, maybe the race with clone(CLONE_VM) does not introduce
false negatives. However a false negative I think will happen when a
task shares mm with another task and also has an additional thread.
Shared mm will increment mm_users without adding to signal->live and
the additional thread will advance signal->live without adding to
mm_users. As a result these increments will balance themselves and
(mm->mm_users > signal->live) condition will yield false negative.
> >
> > Oleg.
> >
next prev parent reply other threads:[~2020-08-21 16:06 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 0:20 [PATCH 1/1] mm, oom_adj: don't loop through tasks in __set_oom_adj when not necessary Suren Baghdasaryan
2020-08-20 5:56 ` Michal Hocko
2020-08-20 8:46 ` Christian Brauner
2020-08-20 9:09 ` Michal Hocko
2020-08-20 10:32 ` Christian Brauner
2020-08-20 11:14 ` Michal Hocko
2020-08-20 10:55 ` Oleg Nesterov
2020-08-20 11:13 ` Michal Hocko
2020-08-20 11:29 ` Michal Hocko
2020-08-20 11:41 ` Oleg Nesterov
2020-08-20 11:47 ` Christian Brauner
2020-08-20 11:30 ` Christian Brauner
2020-08-20 11:42 ` Michal Hocko
2020-08-20 12:41 ` Michal Hocko
2020-08-20 13:43 ` Christian Brauner
2020-08-20 12:34 ` Eric W. Biederman
2020-08-20 12:42 ` Michal Hocko
2020-08-20 12:45 ` Eric W. Biederman
2020-08-20 12:54 ` Eric W. Biederman
2020-08-20 13:26 ` Michal Hocko
2020-08-20 13:34 ` Christian Brauner
2020-08-20 13:48 ` Tetsuo Handa
2020-08-20 14:00 ` Christian Brauner
2020-08-20 14:15 ` Michal Hocko
2020-08-20 14:26 ` Tetsuo Handa
2020-08-20 14:34 ` Michal Hocko
2020-08-20 14:18 ` Tetsuo Handa
2020-08-20 14:49 ` Eric W. Biederman
2020-08-20 15:06 ` Christian Brauner
2020-08-20 15:56 ` Suren Baghdasaryan
2020-08-20 16:26 ` Michal Hocko
2020-08-20 16:29 ` Christian Brauner
2020-08-20 16:47 ` Suren Baghdasaryan
2020-08-21 4:39 ` Eric W. Biederman
2020-08-21 7:17 ` Michal Hocko
2020-08-21 11:15 ` Oleg Nesterov
2020-08-21 15:28 ` Suren Baghdasaryan
2020-08-21 16:06 ` Suren Baghdasaryan [this message]
2020-08-21 16:37 ` Oleg Nesterov
2020-08-21 17:22 ` Suren Baghdasaryan
2020-08-21 16:33 ` Oleg Nesterov
2020-08-21 17:59 ` Oleg Nesterov
2020-08-21 18:53 ` Suren Baghdasaryan
2020-08-24 20:03 ` Suren Baghdasaryan
2020-08-20 13:41 ` Eric W. Biederman
2020-08-20 14:04 ` Oleg Nesterov
2020-08-20 14:36 ` Oleg Nesterov
2020-08-20 15:06 ` Eric W. Biederman
2020-08-20 14:43 ` Eric W. Biederman
2020-08-20 14:12 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJuCfpG06_KLhQyg9N84bRQOdvG27uAZ2oBDEQPR-OnZeNJd1w@mail.gmail.com \
--to=surenb@google.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=areber@redhat.com \
--cc=avagin@gmail.com \
--cc=bernd.edlinger@hotmail.de \
--cc=christian.brauner@ubuntu.com \
--cc=christian@kellner.me \
--cc=cyphar@cyphar.com \
--cc=daniel.m.jordan@oracle.com \
--cc=ebiederm@xmission.com \
--cc=esyr@redhat.com \
--cc=gladkov.alexey@gmail.com \
--cc=john.johansen@canonical.com \
--cc=kernel-team@android.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=shakeelb@google.com \
--cc=tglx@linutronix.de \
--cc=timmurray@google.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).