From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A588EC2D0E4 for ; Tue, 24 Nov 2020 16:42:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AA1E206D5 for ; Tue, 24 Nov 2020 16:42:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DgUQSmvf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390566AbgKXQml (ORCPT ); Tue, 24 Nov 2020 11:42:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390522AbgKXQmk (ORCPT ); Tue, 24 Nov 2020 11:42:40 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90915C0617A6 for ; Tue, 24 Nov 2020 08:42:40 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id c198so2990420wmd.0 for ; Tue, 24 Nov 2020 08:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Dze+9qs3CL67LNyJlDApQNkdcs/suDR4TCdiUKUwE5A=; b=DgUQSmvfX7fcj/3ueVABOb2YXaTAq8629BfhnSrAL77wmv/G3WWdloicSJO1qOCAJE An5T26D2FAVMoBIz6OCinKOBY/et6yFth4/rVoMr4ny58VdfabCYwpqX9Cq3nAPjM16x cOcwWROrqmxs6Ce3c8uBhSOll9lsNQI+L3yJs2aeWjPO13YPkPFO1178al2F3L/MfcdK vhz9rctErIPnpLIXEENVY5medWEIduJF7kczhhGv6D4MfC47Vgi6emGa4GcqUbJj1MMh rn2DK+S86MHAinqNlC7Yd/iro/oGdg+R7jXngJ7I5wW6FAp2Sq+rhe/Acn/770MUE5/g FnZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dze+9qs3CL67LNyJlDApQNkdcs/suDR4TCdiUKUwE5A=; b=Xx/Q0a4SkEKE9Pqs5ilx5NYQ7qipRxEuuANr5+0cCFNy0utdzsWWUC2Sgdp4weHCZC avIcdCics/amZmvbtv39x+l7Rr4MK2j98CNT7YgNzms5Bq3MAB5ewwB0LvlcJiW5PkkN 3PDC6E4cWzOmbKLbpoip2zIjgw8UEDTy67vcTd2q20WS2Ko65e68H1lIuhuj3OcNcr+X Z0jys0UBBc/QAG8VOISNcQUZhg3T5+N3qidHffLiSbhg4K+yuthcGmy6Iu0LGNcnsCnc IzW2S3ALzPeWfTmG+B7M/3JlT76DMZLWVoRZviDxuKXVDofY69pSLMyOCMcKkhiGlQY/ y0kw== X-Gm-Message-State: AOAM530Y/0BPEIDZnHW24IZbkqVQFh82XyAow7jf5CxAWx+04waWeOue JrbsjhZCi4tOHGx4vQ3EyOwgiDY/yV8bkT7E55c+CA== X-Google-Smtp-Source: ABdhPJzcW6Q0VtnxmMDrevqVdV9vRxQg22ghFk+oO5YtNLDLp8wXM2tahrHunqHHAMd1A2ppbwLtFTeuU40+plshnvA= X-Received: by 2002:a1c:ba0b:: with SMTP id k11mr5298401wmf.37.1606236159094; Tue, 24 Nov 2020 08:42:39 -0800 (PST) MIME-Version: 1.0 References: <20201124053943.1684874-1-surenb@google.com> <20201124053943.1684874-3-surenb@google.com> <20201124134208.GA30125@redhat.com> In-Reply-To: <20201124134208.GA30125@redhat.com> From: Suren Baghdasaryan Date: Tue, 24 Nov 2020 08:42:28 -0800 Message-ID: Subject: Re: [PATCH 2/2] mm/madvise: add process_madvise MADV_DONTNEER support To: Oleg Nesterov Cc: Andrew Morton , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Tim Murray , linux-api@vger.kernel.org, linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 5:42 AM Oleg Nesterov wrote: > > On 11/23, Suren Baghdasaryan wrote: > > > > + if (madvise_destructive(behavior)) { > > + /* Allow destructive madvise only on a dying processes */ > > + if (!signal_group_exit(task->signal)) { > > signal_group_exit(task) is true if this task execs and kills other threads, > see the comment above this helper. > > I think you need !(task->signal->flags & SIGNAL_GROUP_EXIT). I see. Thanks for the feedback, Oleg. I'll test and fix it in the next version. > > Oleg. >