From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D570BC6377A for ; Wed, 21 Jul 2021 21:00:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6A636120A for ; Wed, 21 Jul 2021 21:00:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbhGUUTW (ORCPT ); Wed, 21 Jul 2021 16:19:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbhGUUTU (ORCPT ); Wed, 21 Jul 2021 16:19:20 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F204FC061575 for ; Wed, 21 Jul 2021 13:59:56 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id y38so2248698ybi.1 for ; Wed, 21 Jul 2021 13:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zev5RkUDntkX6kWICmg9oLGVZwQDp/V6CB2SFJXvlbM=; b=MbUup/f2IQ4e5MYXEyQSpJT9BA/5+K1mBDGxRAU/j8XHmKaNWC16053kMEmyaCPWU0 6X5d7gRKAa/dn9sXGMMonqNVZSQYg+FgMrgm/oDLmrFHHR6ryPTk24OjWuqiUkf9JhlW PLjjQ9c7rg4CcEE7sbk2wPUqHfE4u7dcmZIHR68kECpIWmNrF1e+HavOLMMowGahLl1N kGlsYJAhDLNMrqMEj2DACIl6eethtxavpitbs31H1qNkaE1Gra0Ryy7rqC6tnXd9j2JL 7GKz6SzksiLzhiITrFIqLM+x66LPrPtZYXLKfOTn1rDr0ivJKphsFhfY2vy2DTZWrCSf Kz9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zev5RkUDntkX6kWICmg9oLGVZwQDp/V6CB2SFJXvlbM=; b=jR4vt+3+XRcQvd7fIa/icsLdGf5f0YoglHO3PXzSeUwWa1SvpXlBrfQIMbxGl2QiSs 1ubS90G5YwrY7DeFb1AeTyVo4ZyLdQQgrYEVIr/YuMTHa7ARHcKydJdJv/d5XcduEMda QRYoXLNcGGW1tgTtx4mX8IgUMCMrG7hCAz/57pJOU7hV2AYMSx0rewrBW9BUeSq0uGj5 HiQ5O/u5oCBoBevQTHA89meTLUVgUA8lfE/evzW2alNDUFzDESpu9o/EFVh1E72aGmRZ o9y4LtgFFPX3RAIHo1ZfLzNLKMFlDLuIGaj0meNPXv9lkwuSZDeURC3Za/tn/iX4KGur nJlQ== X-Gm-Message-State: AOAM531poJpB7UgfCEjpGIinBhbSeSDbRSx1/iz/ZkMGrPUV+mIb4LRK qVH2bHwWRhjp4km/qQnNBJF9Stdc5HdPnJEncn6byA== X-Google-Smtp-Source: ABdhPJxPA+1Lvr6r0Ah+Ih16Hp1gDj0q96HTIeJShNuvXV8XbMIS4BZvdwqDvpclVoKXHc0q16IfDXSgqc30JARLqDQ= X-Received: by 2002:a25:d912:: with SMTP id q18mr44064581ybg.294.1626901195909; Wed, 21 Jul 2021 13:59:55 -0700 (PDT) MIME-Version: 1.0 References: <20210718214134.2619099-1-surenb@google.com> <7eb17da6-03a6-5eaf-16e6-97b53ba163d8@redhat.com> <20210720160707.2332738708948f7d865d67c1@linux-foundation.org> <0ee6775b-589c-3243-1c01-aafad5eecb73@redhat.com> <20210721135056.84d12dd49c07adff7b0beffb@linux-foundation.org> In-Reply-To: <20210721135056.84d12dd49c07adff7b0beffb@linux-foundation.org> From: Suren Baghdasaryan Date: Wed, 21 Jul 2021 13:59:44 -0700 Message-ID: Subject: Re: [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease To: Andrew Morton Cc: David Hildenbrand , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , linux-mm , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 21, 2021 at 1:51 PM Andrew Morton wrote: > > On Wed, 21 Jul 2021 13:19:35 -0700 Suren Baghdasaryan wrote: > > > > > This would not require moving other functions. > > > > Would that be better than the current approach or the forward declaration? > > > > > > IMHO that could be an easy, possible alternative. > > > > Andrew, others? Should I follow this path instead? > > Whatever you prefer ;) I understand David's concern too well to ignore it, so I prefer to follow this middle-ground approach if you don't mind :)