Re: [PATCH v6] pinctrl: add a pin config interface

[Thomas Abraham <thomas.abraham@linaro.org>]

Hi Linus,

On 19 January 2012 22:28, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Jan 18, 2012 at 8:16 AM, Thomas Abraham
> <thomas.abraham@linaro.org> wrote:
>
>> In case of runtime pinmuxing, the pin configuration would also be
>> required to be setup in some cases. pin_config_set() is suitable to be
>> called from the platform code. In case of runtime pinmuxing in driver
>> code, is there any way to set the pin config also at runtime in driver
>> code?
>
> Yes that is already possible today with the pin_config_set() and
> pin_config_group_set() calls already merged for 3.3.
>
> However there is no relation between the struct device and these
> config settings so I feel that this is a bit hack-ish, but it was
> atleast something we could agree upon.

[Resending this email]

Using pin_config_set() from drivers did not seem correct. The concern
here is that all three parameters of pin_config_set() are specific to
a particular platform. Hence, using it in driver means that the driver
will no more be usable across multiple different platforms.

But that was not the case with pinmux_get() and pinmux_put(). Will
there be support added in pinctrl subsystem to allow drivers to
configure pin-config settings from drivers and be compatible for
multiple platforms?

Thanks,
Thomas.

>
> Thanks,
> Linus Walleij