From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1D65C33CB3 for ; Thu, 30 Jan 2020 19:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79566214AF for ; Thu, 30 Jan 2020 19:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580413874; bh=AtsqIu4lBfzodyuXWhO1suFfqe/2gWu7r72L1pzOtMM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=IZdEsatjqCTbCZjTQDV/MwNbovKYEqvVjeoVPDeVgVpRYnRRu+TUcRoM91sqSqb/y XNCmUOkoCdEGb+F95D9AsVPJ4gBrDB/4gpr2bmFVWbgS2u7Kf+2MWndzgHoKFftnyF z9E+5z6/5i4emElPpjO7rS660rmjesBC0AhWS484= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727506AbgA3TvN (ORCPT ); Thu, 30 Jan 2020 14:51:13 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:37797 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgA3TvN (ORCPT ); Thu, 30 Jan 2020 14:51:13 -0500 Received: by mail-ed1-f67.google.com with SMTP id cy15so5170514edb.4; Thu, 30 Jan 2020 11:51:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ny5vawm1ZMouKeDxshhMVR293h8qWKnN6FtNQJsILb4=; b=kZh+JLzy/+gBQVYNkpm2FjZqnjXx8dRvdTABtg1SncnapFb8xPn27HutUBSRbExDOh vbcunYNEji9Jcd3znLmWlGYEuk2Cx98pfj5tzdWFqLh7V8xxU+eCI5uhtngUEVzGfYGb xluHhSTpUsZ5omVTOYEwVUs0n+Qn8PBs0u7yo6Von2nDpgwcQYI6LKtxM9usAdZjz6c6 f6K4+LW7bmDTJzFb8trXFkng10UInb03Yrkc6+9qDTFiX1ef6+Y7SGnB4tqVgGorxNha A/RdL0Rf4MXVaBlYvyOtFQe6YLih+7n8jCURRYWZIkZGapHJ7kgyZhdyPNEi6qNPNKvP 6j5g== X-Gm-Message-State: APjAAAWWbHzgeDqerDk+pShM3GQs3iHXJSs/NDgqNap300BUMvcaumtn 6Wrlk20RIUjWGGBzgBwJiUQj8BGcOvKzKYceWvg= X-Google-Smtp-Source: APXvYqwmdihuWIfIpMtcEl+yOF+MTPbo1EVHcr/7fsjX37sNt7zRBu4Tctxr45lo3mz6klL27jRiosvKJ76XPOF2Vgs= X-Received: by 2002:aa7:d505:: with SMTP id y5mr5551266edq.370.1580413869586; Thu, 30 Jan 2020 11:51:09 -0800 (PST) MIME-Version: 1.0 References: <20191227174055.4923-1-sashal@kernel.org> <20191227174055.4923-16-sashal@kernel.org> In-Reply-To: <20191227174055.4923-16-sashal@kernel.org> From: Len Brown Date: Thu, 30 Jan 2020 14:50:58 -0500 Message-ID: Subject: Re: [PATCH AUTOSEL 5.4 016/187] x86/intel: Disable HPET on Intel Ice Lake platforms To: Sasha Levin Cc: Linux Kernel Mailing List , stable@vger.kernel.org, Kai-Heng Feng , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , feng.tang@intel.com, harry.pan@intel.com, "H. Peter Anvin" , Ingo Molnar , linux-pci@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Can somebody point to an ICL system that is running production-level firmware that exhibits this issue? The hardware people are telling me that zero such systems should exist. (The reported symptom that I've seen is that the TSC vs HPET comparison fails, and Linux keeps the (bad) HPET and disables the (good) TSC) thanks, -Len On Fri, Dec 27, 2019 at 12:41 PM Sasha Levin wrote: > > From: Kai-Heng Feng > > [ Upstream commit e0748539e3d594dd26f0d27a270f14720b22a406 ] > > Like CFL and CFL-H, ICL SoC has skewed HPET timer once it hits PC10. > So let's disable HPET on ICL. > > Signed-off-by: Kai-Heng Feng > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: bp@alien8.de > Cc: feng.tang@intel.com > Cc: harry.pan@intel.com > Cc: hpa@zytor.com > Link: https://lkml.kernel.org/r/20191129062303.18982-2-kai.heng.feng@canonical.com > Signed-off-by: Ingo Molnar > Signed-off-by: Sasha Levin > --- > arch/x86/kernel/early-quirks.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c > index 606711f5ebf8..2f9ec14be3b1 100644 > --- a/arch/x86/kernel/early-quirks.c > +++ b/arch/x86/kernel/early-quirks.c > @@ -714,6 +714,8 @@ static struct chipset early_qrk[] __initdata = { > PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet}, > { PCI_VENDOR_ID_INTEL, 0x3ec4, > PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet}, > + { PCI_VENDOR_ID_INTEL, 0x8a12, > + PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet}, > { PCI_VENDOR_ID_BROADCOM, 0x4331, > PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, 0, apple_airport_reset}, > {} > -- > 2.20.1 > -- Len Brown, Intel Open Source Technology Center