From: Len Brown <lenb@kernel.org>
To: Wyes Karny <wyes.karny@amd.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Doug Smythies <dsmythies@telus.net>
Subject: Re: [PATCH v2] tools/power turbostat: Increase the limit for fd opened
Date: Mon, 27 Nov 2023 20:47:55 -0500 [thread overview]
Message-ID: <CAJvTdKnE4RW7fkHX2r6MvtrC80ynMazgP90KGi7Yump-s3-09g@mail.gmail.com> (raw)
In-Reply-To: <20231003050751.525932-1-wyes.karny@amd.com>
Applied
Thanks Wyes!
On Tue, Oct 3, 2023 at 1:08 AM Wyes Karny <wyes.karny@amd.com> wrote:
>
> When running turbostat, a system with 512 cpus reaches the limit for
> maximum number of file descriptors that can be opened. To solve this
> problem, the limit is raised to 2^15, which is a large enough number.
>
> Below data is collected from AMD server systems while running turbostat:
>
> |-----------+-------------------------------|
> | # of cpus | # of opened fds for turbostat |
> |-----------+-------------------------------|
> | 128 | 260 |
> |-----------+-------------------------------|
> | 192 | 388 |
> |-----------+-------------------------------|
> | 512 | 1028 |
> |-----------+-------------------------------|
>
> So, the new max limit would be sufficient up to 2^14 cpus (but this
> also depends on how many counters are enabled).
>
> Reviewed-by: Doug Smythies <dsmythies@telus.net>
> Tested-by: Doug Smythies <dsmythies@telus.net>
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>
> ---
> v1 -> v2:
> - Take care of already higher rlim_max, rlim_curr
> - Minor tweak in commit text
>
> tools/power/x86/turbostat/turbostat.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 9a10512e3407..1563a0ae7e4c 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -53,6 +53,8 @@
> #define NAME_BYTES 20
> #define PATH_BYTES 128
>
> +#define MAX_NOFILE 0x8000
> +
> enum counter_scope { SCOPE_CPU, SCOPE_CORE, SCOPE_PACKAGE };
> enum counter_type { COUNTER_ITEMS, COUNTER_CYCLES, COUNTER_SECONDS, COUNTER_USEC };
> enum counter_format { FORMAT_RAW, FORMAT_DELTA, FORMAT_PERCENT };
> @@ -6717,6 +6719,22 @@ void cmdline(int argc, char **argv)
> }
> }
>
> +void set_rlimit(void)
> +{
> + struct rlimit limit;
> +
> + if (getrlimit(RLIMIT_NOFILE, &limit) < 0)
> + err(1, "Failed to get rlimit");
> +
> + if (limit.rlim_max < MAX_NOFILE)
> + limit.rlim_max = MAX_NOFILE;
> + if (limit.rlim_cur < MAX_NOFILE)
> + limit.rlim_cur = MAX_NOFILE;
> +
> + if (setrlimit(RLIMIT_NOFILE, &limit) < 0)
> + err(1, "Failed to set rlimit");
> +}
> +
> int main(int argc, char **argv)
> {
> outf = stderr;
> @@ -6729,6 +6747,9 @@ int main(int argc, char **argv)
>
> probe_sysfs();
>
> + if (!getuid())
> + set_rlimit();
> +
> turbostat_init();
>
> msr_sum_record();
> --
> 2.34.1
>
--
Len Brown, Intel
prev parent reply other threads:[~2023-11-28 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 5:07 [PATCH v2] tools/power turbostat: Increase the limit for fd opened Wyes Karny
2023-11-02 15:01 ` Wyes Karny
2023-11-28 1:47 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvTdKnE4RW7fkHX2r6MvtrC80ynMazgP90KGi7Yump-s3-09g@mail.gmail.com \
--to=lenb@kernel.org \
--cc=dsmythies@telus.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=wyes.karny@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).