From: Dmitry Safonov <0x7f454c46@gmail.com>
To: Adrian Reber <areber@redhat.com>
Cc: Christian Brauner <christian@brauner.io>,
Eric Biederman <ebiederm@xmission.com>,
Pavel Emelianov <xemul@virtuozzo.com>,
Jann Horn <jannh@google.com>,
open list <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>, Andrei Vagin <avagin@gmail.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Radostin Stoyanov <rstoyanov1@gmail.com>
Subject: Re: [PATCH 1/2] fork: extend clone3() to support CLONE_SET_TID
Date: Mon, 29 Jul 2019 20:17:58 +0100 [thread overview]
Message-ID: <CAJwJo6baR_w_sE8Qtr4Le9KTLWx0Qzi99qmoTm+6hd1j1UkmFA@mail.gmail.com> (raw)
In-Reply-To: <CAJwJo6Z5qHThG5wECSn+jiS0iM3smuXA1OS96Gho1HL-gD=RKQ@mail.gmail.com>
On Mon, 29 Jul 2019 at 20:12, Dmitry Safonov <0x7f454c46@gmail.com> wrote:
>
> On Mon, 29 Jul 2019 at 17:52, Adrian Reber <areber@redhat.com> wrote:
> [..]
> > --- a/include/uapi/linux/sched.h
> > +++ b/include/uapi/linux/sched.h
> > @@ -32,6 +32,7 @@
> > #define CLONE_NEWPID 0x20000000 /* New pid namespace */
> > #define CLONE_NEWNET 0x40000000 /* New network namespace */
> > #define CLONE_IO 0x80000000 /* Clone io context */
> > +#define CLONE_SET_TID 0x100000000ULL /* set if the desired TID is set in set_tid */
> >
> > /*
> > * Arguments for the clone3 syscall
> > @@ -45,6 +46,7 @@ struct clone_args {
> > __aligned_u64 stack;
> > __aligned_u64 stack_size;
> > __aligned_u64 tls;
> > + __aligned_u64 set_tid;
> > };
> >
>
> I don't see a change to
> : if (unlikely(size < sizeof(struct clone_args)))
> : return -EINVAL;
>
> That seems backwards-incompatible, but I may miss some part..
On the other hand, clone3() was merged in v5.3 window, so probably,
it doesn't matter.
--
Dmitry
next prev parent reply other threads:[~2019-07-29 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 16:33 [PATCH 1/2] fork: extend clone3() to support CLONE_SET_TID Adrian Reber
2019-07-29 16:33 ` [PATCH 2/2] selftests: add test for clone3() with set_tid Adrian Reber
2019-07-29 19:12 ` [PATCH 1/2] fork: extend clone3() to support CLONE_SET_TID Dmitry Safonov
2019-07-29 19:17 ` Dmitry Safonov [this message]
2019-07-29 19:33 ` Christian Brauner
2019-07-30 16:55 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJwJo6baR_w_sE8Qtr4Le9KTLWx0Qzi99qmoTm+6hd1j1UkmFA@mail.gmail.com \
--to=0x7f454c46@gmail.com \
--cc=areber@redhat.com \
--cc=avagin@gmail.com \
--cc=christian@brauner.io \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=rstoyanov1@gmail.com \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).