From: Kevin Cernekee <cernekee@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
dgreid@chromium.org, Andrew Bresticker <abrestic@chromium.org>,
Olof Johansson <olofj@chromium.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers
Date: Mon, 4 May 2015 06:51:32 -0700 [thread overview]
Message-ID: <CAJzqFtYm6W40B05DG5yfa5iOaUo3ShJOm6AXcOQ1ehUOG0yO6A@mail.gmail.com> (raw)
In-Reply-To: <20150504114558.GD15510@sirena.org.uk>
On Mon, May 4, 2015 at 4:45 AM, Mark Brown <broonie@kernel.org> wrote:
> On Sun, May 03, 2015 at 05:00:18PM -0700, Kevin Cernekee wrote:
>> + if (dev->of_node) {
>> + const struct of_device_id *of_id;
>> +
>> + of_id = of_match_device(tas571x_of_match, dev);
>> + if (of_id)
>> + priv->chip = of_id->data;
>> + }
>
> Doesn't of_match_device() do the right thing with devices not registered
> from DT?
Not sure. What kinds of situations are you concerned about?
next prev parent reply other threads:[~2015-05-04 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 0:00 [PATCH V3 0/4] tas571x amplifier driver Kevin Cernekee
2015-05-04 0:00 ` [PATCH V3 1/4] regmap: Use regcache_mark_dirty() to indicate power loss or reset Kevin Cernekee
2015-05-04 6:38 ` Lars-Peter Clausen
2015-05-04 14:05 ` Kevin Cernekee
2015-05-04 17:33 ` Lars-Peter Clausen
2015-05-04 0:00 ` [PATCH V3 2/4] ASoC: tas571x: Add DT binding document Kevin Cernekee
2015-05-04 0:00 ` [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers Kevin Cernekee
2015-05-04 11:45 ` Mark Brown
2015-05-04 13:51 ` Kevin Cernekee [this message]
2015-05-04 13:57 ` Mark Brown
2015-05-04 0:00 ` [PATCH V3 4/4] MAINTAINERS: Add entry for tas571x ASoC codec driver Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJzqFtYm6W40B05DG5yfa5iOaUo3ShJOm6AXcOQ1ehUOG0yO6A@mail.gmail.com \
--to=cernekee@chromium.org \
--cc=abrestic@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).