From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB86C678DB for ; Fri, 24 Feb 2023 10:22:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229778AbjBXKWq (ORCPT ); Fri, 24 Feb 2023 05:22:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbjBXKWn (ORCPT ); Fri, 24 Feb 2023 05:22:43 -0500 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BB4B1CF46; Fri, 24 Feb 2023 02:22:42 -0800 (PST) Received: by mail-qt1-x836.google.com with SMTP id c18so440308qte.5; Fri, 24 Feb 2023 02:22:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5ArdJ82Ti4o0RpCTc3la0LvQj32FhuvjhyjGEJAFaRo=; b=dC+nfr7TtVnR4AooU8jYBSOyZWFE53uaJTrXRf5ZXHxMwrkYb4cFtOFFOLVfq+yuaf OCWXKw+rE9CPImvyXqhS1lHmHVFuzDbh7Yho2IjAwkZvRxQQHXpTje8n7N/cikNyyEx0 s7MgUWDsxzLWKqMbSFfyedo7TKCmnOdeNQLFv/LLv4P18NaLFYruLreA/4PLeBwIFkR5 VCPGLjMT7UkAwXXpf/mw3F4vcnnAImVXxUW5TLc55VFmnPiUNCBZpeQZwRrptQZMFdN2 L31ydk5THOP0hdu2l1zdkZLp4UxVS2TVrrBZpoMNJGDaLGHVx4sM0q7lxdNEY2tqwlXd +cWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5ArdJ82Ti4o0RpCTc3la0LvQj32FhuvjhyjGEJAFaRo=; b=bIbZvEjNdncOBtmR2z6EP/z6S53cGy7MmzwhI421v0qX+iNfqANdswZ0C1JVMpycb9 Oszsjmdw+32AjZcALTCTvLLmXru3AK1L+ln1pufbFnprqeF1wd+kziz3U1yT5K3LxTCI TBZ7yZtijBcNcIh20KLxdA0pxksQFzOzU38UahbEHLy1pn1rzJj79S1+7UE5it3odeLN SNP0Hn5CEgxYoee2xtxom4fh/JyLYFXDYYkuPBa88L47vXEJ8hj0SMvSJS7JwEI3kc+X MoVvs8unP4IjArww+JLbfhEzzUmiWqYhNdShtUyR7UOUUKAreSkLDnMEldC4oorS3mdW NZ4g== X-Gm-Message-State: AO0yUKVyKysLexonkdvxxDcN3nP5PrCP/rvVuaIT5dcxhs32r+4zGVqR OF4FD/pMksH6XM0lMwjWu98N8odyM80B40SIK1U= X-Google-Smtp-Source: AK7set+lNXXxsCgvZ4t+iXZH2vNnwUUFCHa+MJV8RpOpu6jfJWo34rHQetYrPNWTBHzkKFezpLRWlPO/VD3cWQvBCKo= X-Received: by 2002:ac8:604e:0:b0:3bd:6c0:933d with SMTP id k14-20020ac8604e000000b003bd06c0933dmr2758827qtm.10.1677234161233; Fri, 24 Feb 2023 02:22:41 -0800 (PST) MIME-Version: 1.0 References: <20221213090047.3805-1-victor.shih@genesyslogic.com.tw> <20221213090047.3805-2-victor.shih@genesyslogic.com.tw> <1dc8942d-b7c7-144b-f5a1-a3f614f159ff@intel.com> In-Reply-To: <1dc8942d-b7c7-144b-f5a1-a3f614f159ff@intel.com> From: Victor Shih Date: Fri, 24 Feb 2023 18:22:29 +0800 Message-ID: Subject: Re: [PATCH V6 01/24] mmc: core: Cleanup printing of speed mode at card insertion To: Adrian Hunter Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, benchuanggli@gmail.com, HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw, takahiro.akashi@linaro.org, dlunev@chromium.org, Victor Shih Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Adrian On Fri, Jan 6, 2023 at 5:22 AM Adrian Hunter wrote: > > On 13/12/22 11:00, Victor Shih wrote: > > The current print of the bus speed mode in mmc_add_card() has grown over > > the years and is now difficult to parse. Let's clean up the code and also > > take the opportunity to properly announce "DDR" for eMMCs as > > "high speed DDR", which is according to the eMMC spec. > > > > Signed-off-by: Ulf Hansson > > Signed-off-by: Victor Shih > > --- > > drivers/mmc/core/bus.c | 35 ++++++++++++++++++++--------------- > > 1 file changed, 20 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c > > index 36679f4e9acc..bbbbdbca5366 100644 > > --- a/drivers/mmc/core/bus.c > > +++ b/drivers/mmc/core/bus.c > > @@ -299,6 +299,7 @@ int mmc_add_card(struct mmc_card *card) > > { > > int ret; > > const char *type; > > + const char *speed_mode = ""; > > const char *uhs_bus_speed_mode = ""; > > static const char *const uhs_speeds[] = { > > [UHS_SDR12_BUS_SPEED] = "SDR12 ", > > @@ -337,25 +338,29 @@ int mmc_add_card(struct mmc_card *card) > > break; > > } > > > > + if (mmc_card_hs(card)) > > + speed_mode = "high speed "; > > + else if (mmc_card_uhs(card)) > > + speed_mode = "ultra high speed "; > > + else if (mmc_card_ddr52(card)) > > + speed_mode = "high speed DDR "; > > + else if (mmc_card_hs200(card)) > > + speed_mode = "HS200 "; > > + else if (mmc_card_hs400es(card)) > > + speed_mode = "HS400 Enhanced strobe "; > > + else if (mmc_card_hs400(card)) > > + speed_mode = "HS400 "; > > + > > if (mmc_card_uhs(card) && > > (card->sd_bus_speed < ARRAY_SIZE(uhs_speeds))) > > uhs_bus_speed_mode = uhs_speeds[card->sd_bus_speed]; > > > > - if (mmc_host_is_spi(card->host)) { > > - pr_info("%s: new %s%s%s card on SPI\n", > > - mmc_hostname(card->host), > > - mmc_card_hs(card) ? "high speed " : "", > > - mmc_card_ddr52(card) ? "DDR " : "", > > - type); > > - } else { > > - pr_info("%s: new %s%s%s%s%s%s card at address %04x\n", > > - mmc_hostname(card->host), > > - mmc_card_uhs(card) ? "ultra high speed " : > > - (mmc_card_hs(card) ? "high speed " : ""), > > - mmc_card_hs400(card) ? "HS400 " : > > - (mmc_card_hs200(card) ? "HS200 " : ""), > > - mmc_card_hs400es(card) ? "Enhanced strobe " : "", > > - mmc_card_ddr52(card) ? "DDR " : "", > > + if (mmc_host_is_spi(card->host)) > > + pr_info("%s: new %s%s card on SPI\n", > > + mmc_hostname(card->host), speed_mode, type); > > + else { > > This bracket wasn't in V5. Brackets should be on both > branches of the if-clause or neither. > I will update it in V7 version. > > + pr_info("%s: new %s%s%s card at address %04x\n", > > + mmc_hostname(card->host), speed_mode, > > uhs_bus_speed_mode, type, card->rca); > > } > > > Thanks, Victor Shih