Re: [PATCH V5 00/26] Add support UHS-II for GL9755

From: Victor Shih <victorshihgli@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: adrian.hunter@intel.com, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, benchuanggli@gmail.com,
	HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw,
	takahiro.akashi@linaro.org, dlunev@chromium.org,
	Victor Shih <victor.shih@genesyslogic.com.tw>
Subject: Re: [PATCH V5 00/26] Add support UHS-II for GL9755
Date: Wed, 19 Oct 2022 19:02:42 +0800	[thread overview]
Message-ID: <CAK00qKD3XqnwSkc3rDQ67zMizPLo3Qt8in4S-GNXAvuNcMsY-g@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFr4je2WhF8oQW1CpQD+2dRZhn+5JB0bLqHjLDTOiao58g@mail.gmail.com>

Hi, Ulf

Ulf Hansson <ulf.hansson@linaro.org> 於 2022年10月17日 週一 晚上7:32寫道：

>
> Hi Victor,
>
> On Fri, 14 Oct 2022 at 13:47, Victor Shih <victorshihgli@gmail.com> wrote:
> >
> > Summary
> > =======
> > These patches[1] support UHS-II and fix GL9755 UHS-II compatibility.
> >
> > About UHS-II, roughly deal with the following three parts:
> > 1) A UHS-II detection and initialization:
> > - Host setup to support UHS-II (Section 3.13.1 Host Controller Setup Sequence
> >   [2]).
> > - Detect a UHS-II I/F (Section 3.13.2 Card Interface Detection Sequence[2]).
> > - In step(9) of Section 3.13.2 in [2], UHS-II initialization is include Section
> >   3.13.3 UHS-II Card Initialization and Section 3.13.4 UHS-II Setting Register
> >   Setup Sequence.
> >
> > 2) Send Legacy SD command through SD-TRAN
> > - Encapsulated SD packets are defined in SD-TRAN in order to ensure Legacy SD
> >   compatibility and preserve Legacy SD infrastructures (Section 7.1.1 Packet
> >   Types and Format Overview[3]).
> > - Host issue a UHS-II CCMD packet or a UHS-II DCMD (Section 3.13.5 UHS-II
> >   CCMD Packet issuing and Section 3.13.6 UHS-II DCMD Packet issuing[2]).
> >
> > 3) UHS-II Interrupt
> > - Except for UHS-II error interrupts, most interrupts share the original
> >   interrupt registers.
> >
> > Patch structure
> > ===============
> > patch#1-#6:  for core
> > patch#7-#25: for sdhci
> > patch#26:    for GL9755
> >
> > Changes in v5 (Oct. 14, 2022)
> > * rebased to linux-v6.0.
>
> You sent a v5 on Oct 14 and then this one (v5 again) today. Why? What
> is the difference?

I left out two files in the October 14th edition, so I added it back
in the October 17th edition, but I forgot to change the date of the
cover-letter.

>
> Moreover, as v6.1-rc1 is now available, my next branch will be based
> on that. Can you please rebase the series on top of my next branch -
> or at least use the latest available "rc", when you test and submit?

Ok, I will follow your advice.
I will rebase to the linux-v6.1-rc1 in your next branch.

>
> > * according to the guidance and overall architecture provided
> >   by Ulf Hansson, Ben Chuang and Jason Lai to implement the
> >   UHS-2 Core function based on the patches of the [V4,0/6]
> >   Preparations to support SD UHS-II cards[5].
> > * according to the guidance and comments provided by
> >   Adrian Hunter, Ben Chuang and AKASHI Takahiro to implement
> >   the UHS-2 Host function based on the patches of the
> >   [RFC,v3.1,00/27] Add support UHS-II for GL9755[4].
> > * implement the necessary function to let the UHS-2 Core/Host
> >   work properly.
> > * fix most of checkpatch warnings/errors
> >
> > Reference
> > =========
> > [1] https://gitlab.com/ben.chuang/linux-uhs2-gl9755.git
> > [2] SD Host Controller Simplified Specification 4.20
> > [3] UHS-II Simplified Addendum 1.02
> > [4] https://patchwork.kernel.org/project/linux-mmc/cover/20201106022726.19831-1-takahiro.akashi@linaro.org/
> > [5] https://patchwork.kernel.org/project/linux-mmc/cover/20220418115833.10738-1-jasonlai.genesyslogic@gmail.com/
>
> Another general question, I assume you intend to move this forward
> instead of Jason Lai, right?

Yes. Please let me know if I have any mistakes.

>
> Kind regards
> Uffe

Thanks, Victor Shih