Re: [PATCH 3/4] x86: save user rsp in pt_regs->sp on SYSCALL64 fastpath

From: Denys Vlasenko <vda.linux@googlemail.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Alexei Starovoitov <ast@plumgrid.com>,
	Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
	X86 ML <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] x86: save user rsp in pt_regs->sp on SYSCALL64 fastpath
Date: Mon, 9 Mar 2015 21:32:33 +0100	[thread overview]
Message-ID: <CAK1hOcM-MLX=03YbuBUZCj5koEWRa4GbE=f566hruEat_MUjPQ@mail.gmail.com> (raw)
In-Reply-To: <CALCETrUJ4Db8JbRqA8pYm4V=bBG5xwm9NFmT7H0h66v68JeCGQ@mail.gmail.com>

On Mon, Mar 9, 2015 at 9:11 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>> @@ -253,11 +247,13 @@ GLOBAL(system_call_after_swapgs)
>>          */
>>         ENABLE_INTERRUPTS(CLBR_NONE)
>>         ALLOC_PT_GPREGS_ON_STACK 8              /* +8: space for orig_ax */
>> +       movq    %rcx,RIP(%rsp)
>> +       movq    PER_CPU_VAR(old_rsp),%rcx
>> +       movq    %r11,EFLAGS(%rsp)
>> +       movq    %rcx,RSP(%rsp)
>> +       movq_cfi rax,ORIG_RAX
>>         SAVE_C_REGS_EXCEPT_RAX_RCX_R11
>>         movq    $-ENOSYS,RAX(%rsp)
>> -       movq_cfi rax,ORIG_RAX
>> -       movq    %r11,EFLAGS(%rsp)
>> -       movq    %rcx,RIP(%rsp)
>
> Why the reordering?

No strong reason.

iret stack is "above" the rest of pt_regs.

This does not matter now, but when/if we convert to PUSHes
for register saving, pushes which build iret frame
will have to be before "save C-clobbered registers" part,
exactly as in this patch.